Skip to content

Conversation

@GoeLin
Copy link
Member

@GoeLin GoeLin commented Oct 26, 2025

I backport this for parity with 17.0.18-oracle.

First, there was the attempt to delete these events, see backport of https://bugs.openjdk.org/browse/JDK-8291733: Remove JFR events that expose hashtable

@eghalin pointed out to me that Oracle reverts this (See JDK-8369975 [BACKOUT BACKPORT] Remove JFR events that expose hashtable) and instead disables the events,
see also comment in #4047

This now implements the backport according to that comment.

Thanks again, Eric, for informing about this.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8369992 needs maintainer approval

Issue

  • JDK-8369992: JFR: Disable Placeholder-, LoaderConstraints- and ProtectionDomainCacheTableStatistics in default.jfc (Bug - P3)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/4108/head:pull/4108
$ git checkout pull/4108

Update a local copy of the PR:
$ git checkout pull/4108
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/4108/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4108

View PR using the GUI difftool:
$ git pr show -t 4108

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/4108.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 26, 2025

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 26, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title backport JDK-8369992 8369992: JFR: Disable Placeholder-, LoaderConstraints- and ProtectionDomainCacheTableStatistics in default.jfc Oct 26, 2025
@openjdk
Copy link

openjdk bot commented Oct 26, 2025

This backport pull request has now been updated with the original issue, but not the original commit. If you have the original commit hash, please update the pull request title with Backport <hash>.

@openjdk openjdk bot added backport Port of a pull request already in a different code base rfr Pull request is ready for review labels Oct 26, 2025
@mlbridge
Copy link

mlbridge bot commented Oct 26, 2025

Webrevs

@GoeLin
Copy link
Member Author

GoeLin commented Oct 27, 2025

GHA failure: java/lang/ProcessBuilder/Basic#id0 failed. Unrelated.
Might be fixed by #4097

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant