Skip to content

Conversation

@GoeLin
Copy link
Member

@GoeLin GoeLin commented Oct 25, 2025

I backport this to simplify later test backports that touch the files in the new locations.

This is not based on the backport to 21. That backport includes Comm.java. When I did that, it had not planned to backport follow-up "8343876:` Enhancements to jpackage test lib" that brings Comm.java. But as I did that in the meantime I think it is better to add that part there. The backport from 21 would not have been clean, anyways,
nor backporting 8343876 from 21 on top.

Omitted PredefinedAppImageErrorTest.java‎. Was added by "8286850: [macos] Add support for signing user provided app image" in 19.

test/jdk/tools/jpackage/windows/WinL10nTest.java
Code modified was added by "8291978: jpackage: allow to override primary l10n files on Windows" in 20. Omitted.

BasicTest.java requires TKit.assertDirectoryContent(). This was added by 8325089: jpackage utility creates an "infinite", undeleteable directory tree.
Too big to backport as prereq, so I add that to TKit as I already did in the backport to 21.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8344326 needs maintainer approval

Issue

  • JDK-8344326: Move jpackage tests from "jdk.jpackage.tests" package to the default package (Enhancement - P4 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/4105/head:pull/4105
$ git checkout pull/4105

Update a local copy of the PR:
$ git checkout pull/4105
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/4105/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4105

View PR using the GUI difftool:
$ git pr show -t 4105

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/4105.diff

Using Webrev

Link to Webrev Comment

@GoeLin GoeLin changed the title Goetz backport 8344326 backport 2c509a158fad63e69a8072fa4a7588eaacf37dc0 Oct 25, 2025
@bridgekeeper
Copy link

bridgekeeper bot commented Oct 25, 2025

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 25, 2025

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8344326: Move jpackage tests from "jdk.jpackage.tests" package to the default package

Reviewed-by: mbaesken

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 10 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title backport 2c509a158fad63e69a8072fa4a7588eaacf37dc0 8344326: Move jpackage tests from "jdk.jpackage.tests" package to the default package Oct 25, 2025
@openjdk
Copy link

openjdk bot commented Oct 25, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base rfr Pull request is ready for review labels Oct 25, 2025
@mlbridge
Copy link

mlbridge bot commented Oct 25, 2025

Webrevs

@GoeLin
Copy link
Member Author

GoeLin commented Oct 26, 2025

GHA failure: java/lang/ProcessBuilder/Basic#id0 failed. Unrelated.

@GoeLin
Copy link
Member Author

GoeLin commented Oct 26, 2025

GHA failure: java/lang/ProcessBuilder/Basic#id0 failed. Unrelated.

@openjdk
Copy link

openjdk bot commented Oct 28, 2025

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@GoeLin
Copy link
Member Author

GoeLin commented Oct 28, 2025

Thanks for the reviews!

@openjdk openjdk bot added approval Requires approval; will be removed when approval is received ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Oct 28, 2025
@GoeLin
Copy link
Member Author

GoeLin commented Oct 28, 2025

/integrate

@openjdk
Copy link

openjdk bot commented Oct 28, 2025

Going to push as commit d270974.
Since your change was applied there have been 10 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 28, 2025
@openjdk openjdk bot closed this Oct 28, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 28, 2025
@openjdk
Copy link

openjdk bot commented Oct 28, 2025

@GoeLin Pushed as commit d270974.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin GoeLin deleted the goetz_backport_8344326 branch October 28, 2025 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants