-
Couldn't load subscription status.
- Fork 232
8344326: Move jpackage tests from "jdk.jpackage.tests" package to the default package #4105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back goetz! A progress list of the required criteria for merging this PR into |
|
@GoeLin This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 10 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
|
This backport pull request has now been updated with issue from the original commit. |
|
GHA failure: java/lang/ProcessBuilder/Basic#id0 failed. Unrelated. |
|
GHA failure: java/lang/ProcessBuilder/Basic#id0 failed. Unrelated. |
|
|
|
Thanks for the reviews! |
|
/integrate |
|
Going to push as commit d270974.
Your commit was automatically rebased without conflicts. |
I backport this to simplify later test backports that touch the files in the new locations.
This is not based on the backport to 21. That backport includes Comm.java. When I did that, it had not planned to backport follow-up "8343876:` Enhancements to jpackage test lib" that brings Comm.java. But as I did that in the meantime I think it is better to add that part there. The backport from 21 would not have been clean, anyways,
nor backporting 8343876 from 21 on top.
Omitted PredefinedAppImageErrorTest.java. Was added by "8286850: [macos] Add support for signing user provided app image" in 19.
test/jdk/tools/jpackage/windows/WinL10nTest.java
Code modified was added by "8291978: jpackage: allow to override primary l10n files on Windows" in 20. Omitted.
BasicTest.java requires TKit.assertDirectoryContent(). This was added by 8325089: jpackage utility creates an "infinite", undeleteable directory tree.
Too big to backport as prereq, so I add that to TKit as I already did in the backport to 21.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/4105/head:pull/4105$ git checkout pull/4105Update a local copy of the PR:
$ git checkout pull/4105$ git pull https://git.openjdk.org/jdk17u-dev.git pull/4105/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 4105View PR using the GUI difftool:
$ git pr show -t 4105Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/4105.diff
Using Webrev
Link to Webrev Comment