Skip to content

Conversation

@MBaesken
Copy link
Member

@MBaesken MBaesken commented Oct 23, 2025


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8363676 needs maintainer approval

Issue

  • JDK-8363676: [GCC static analyzer] missing return value check of malloc in OGLContext_SetTransform (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/4095/head:pull/4095
$ git checkout pull/4095

Update a local copy of the PR:
$ git checkout pull/4095
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/4095/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4095

View PR using the GUI difftool:
$ git pr show -t 4095

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/4095.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 23, 2025

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 23, 2025

@MBaesken This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8363676: [GCC static analyzer] missing return value check of malloc in OGLContext_SetTransform

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 0f26915: 8334771: [TESTBUG] Run TestDockerMemoryMetrics.java with -Xcomp fails exitValue = 137

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport d25ad881ebfec40ca6b0a73f78d1f9d2cb722e01 8363676: [GCC static analyzer] missing return value check of malloc in OGLContext_SetTransform Oct 23, 2025
@openjdk
Copy link

openjdk bot commented Oct 23, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Oct 23, 2025
@openjdk
Copy link

openjdk bot commented Oct 23, 2025

⚠️ @MBaesken This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added rfr Pull request is ready for review approval Requires approval; will be removed when approval is received labels Oct 23, 2025
@mlbridge
Copy link

mlbridge bot commented Oct 23, 2025

Webrevs

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Oct 24, 2025
@MBaesken
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Oct 29, 2025

Going to push as commit be5ae4c.
Since your change was applied there have been 34 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 29, 2025
@openjdk openjdk bot closed this Oct 29, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 29, 2025
@openjdk
Copy link

openjdk bot commented Oct 29, 2025

@MBaesken Pushed as commit be5ae4c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

1 participant