-
Couldn't load subscription status.
- Fork 232
8352678: Opensource few JMenuItem tests #4049
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
👋 Welcome back ssubramaniam! A progress list of the required criteria for merging this PR into |
|
/issue add 8357305 |
|
@satyenme This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 59 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
|
This backport pull request has now been updated with issue from the original commit. |
|
@satyenme |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks equivalent to openjdk/jdk21u-dev#2332.
|
|
|
/approval request for backport of JDK-8352678: Opensource few JMenuItem tests and 8357305: Compilation failure in javax/swing/JMenuItem/bug6197830.java. Motivation: With this change, we provide additional test coverage without changing any functionality (so minimal risk). Change will bring openjdk closer to matching oracle. Choosing to backport these together, since the first change fails to compile. Risk: Low. Ran GHA Sanity Checks and new manual tests. Patch is clean. Although change has only been present in tip since May, 2025, change has been accepted by Oracle (and tests were previously closed source). |
Backporting JDK-8352678: Opensource few JMenuItem tests and JDK-8357305: Compilation failure in javax/swing/JMenuItem/bug6197830.java (caused by first JBS issue). Renames a test file, and open sources 4 tests. Ran GHA Sanity Checks and new tests directly.
Progress
Issues
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/4049/head:pull/4049$ git checkout pull/4049Update a local copy of the PR:
$ git checkout pull/4049$ git pull https://git.openjdk.org/jdk17u-dev.git pull/4049/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 4049View PR using the GUI difftool:
$ git pr show -t 4049Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/4049.diff
Using Webrev
Link to Webrev Comment