Skip to content

Conversation

@satyenme
Copy link

@satyenme satyenme commented Oct 15, 2025

Backporting JDK-8352678: Opensource few JMenuItem tests and JDK-8357305: Compilation failure in javax/swing/JMenuItem/bug6197830.java (caused by first JBS issue). Renames a test file, and open sources 4 tests. Ran GHA Sanity Checks and new tests directly.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8352678 needs maintainer approval
  • JDK-8357305 needs maintainer approval

Issues

  • JDK-8352678: Opensource few JMenuItem tests (Bug - P4 - Approved)
  • JDK-8357305: Compilation failure in javax/swing/JMenuItem/bug6197830.java (Bug - P3 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/4049/head:pull/4049
$ git checkout pull/4049

Update a local copy of the PR:
$ git checkout pull/4049
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/4049/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4049

View PR using the GUI difftool:
$ git pr show -t 4049

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/4049.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 15, 2025

👋 Welcome back ssubramaniam! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@satyenme
Copy link
Author

/issue add 8357305

@openjdk
Copy link

openjdk bot commented Oct 15, 2025

@satyenme This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8352678: Opensource few JMenuItem tests
8357305: Compilation failure in javax/swing/JMenuItem/bug6197830.java

Reviewed-by: shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 59 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 8a40498d79a18dcf91cf4979d34c3583a6c39322 8352678: Opensource few JMenuItem tests Oct 15, 2025
@openjdk
Copy link

openjdk bot commented Oct 15, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base rfr Pull request is ready for review labels Oct 15, 2025
@openjdk
Copy link

openjdk bot commented Oct 15, 2025

@satyenme
Adding additional issue to issue list: 8357305: Compilation failure in javax/swing/JMenuItem/bug6197830.java.

@mlbridge
Copy link

mlbridge bot commented Oct 15, 2025

Webrevs

Copy link
Member

@shipilev shipilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks equivalent to openjdk/jdk21u-dev#2332.

@openjdk
Copy link

openjdk bot commented Oct 24, 2025

⚠️ @satyenme This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@satyenme
Copy link
Author

/approval request for backport of JDK-8352678: Opensource few JMenuItem tests and 8357305: Compilation failure in javax/swing/JMenuItem/bug6197830.java.

Motivation: With this change, we provide additional test coverage without changing any functionality (so minimal risk). Change will bring openjdk closer to matching oracle. Choosing to backport these together, since the first change fails to compile.

Risk: Low. Ran GHA Sanity Checks and new manual tests. Patch is clean. Although change has only been present in tip since May, 2025, change has been accepted by Oracle (and tests were previously closed source).

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Oct 24, 2025
@openjdk
Copy link

openjdk bot commented Oct 24, 2025

@satyenme
8352678: The approval request was already up to date.
8357305: The approval request was already up to date.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Oct 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base ready Pull request is ready to be integrated rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

2 participants