-
Notifications
You must be signed in to change notification settings - Fork 251
8333200: Test containers/docker/TestPids.java fails Limit value -1 is not accepted as unlimited #3102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8333200: Test containers/docker/TestPids.java fails Limit value -1 is not accepted as unlimited #3102
Conversation
|
👋 Welcome back syan! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
|
This backport pull request has now been updated with issue from the original commit. |
|
|
Webrevs
|
|
@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a |
|
My understanding of this bug is that it was a follow-on fix for JDK-8302744 which is only present in 21u and 23+. Are you seeing this fail on 11u? Even if this is needed in 11u, we would not skip backporting this change to 17u first without good reason. |
I do not seen this fails on jdk17 and jdk11 for now. This backport PR will make test more robustness and no harm in theory, and I verified this patch locally, after this patch test still run passed. I think we should close this backport PR. Apologize for the interrupt. And thanks for the analysis @franferrax |
Hi all,
This pull request contains a backport of commit 7ab74c5f from the openjdk/jdk repository.
The commit being backported was authored by SendaoYan on 31 May 2024 and was reviewed by Severin Gehwolf.
Thanks!
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/3102/head:pull/3102$ git checkout pull/3102Update a local copy of the PR:
$ git checkout pull/3102$ git pull https://git.openjdk.org/jdk11u-dev.git pull/3102/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 3102View PR using the GUI difftool:
$ git pr show -t 3102Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/3102.diff
Using Webrev
Link to Webrev Comment