Skip to content

Conversation

@sendaoYan
Copy link
Member

@sendaoYan sendaoYan commented Sep 23, 2025

Hi all,

This pull request contains a backport of commit 7ab74c5f from the openjdk/jdk repository.

The commit being backported was authored by SendaoYan on 31 May 2024 and was reviewed by Severin Gehwolf.

Thanks!


Progress

  • JDK-8333200 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8333200: Test containers/docker/TestPids.java fails Limit value -1 is not accepted as unlimited (Bug - P2)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/3102/head:pull/3102
$ git checkout pull/3102

Update a local copy of the PR:
$ git checkout pull/3102
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/3102/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3102

View PR using the GUI difftool:
$ git pr show -t 3102

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/3102.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 23, 2025

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 23, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 7ab74c5f268dac82bbd36355acf8e4f3d357134c 8333200: Test containers/docker/TestPids.java fails Limit value -1 is not accepted as unlimited Sep 23, 2025
@openjdk
Copy link

openjdk bot commented Sep 23, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Sep 23, 2025
@openjdk
Copy link

openjdk bot commented Sep 23, 2025

⚠️ @sendaoYan This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 23, 2025
@mlbridge
Copy link

mlbridge bot commented Sep 23, 2025

Webrevs

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 21, 2025

@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@gnu-andrew
Copy link
Member

My understanding of this bug is that it was a follow-on fix for JDK-8302744 which is only present in 21u and 23+. Are you seeing this fail on 11u?

Even if this is needed in 11u, we would not skip backporting this change to 17u first without good reason.

@sendaoYan
Copy link
Member Author

My understanding of this bug is that it was a follow-on fix for JDK-8302744 which is only present in 21u and 23+. Are you seeing this fail on 11u?

Even if this is needed in 11u, we would not skip backporting this change to 17u first without good reason.

I do not seen this fails on jdk17 and jdk11 for now. This backport PR will make test more robustness and no harm in theory, and I verified this patch locally, after this patch test still run passed.
Bu since JDK-8333200 do not affected jdk17 and jdk11, I think we do not have strong reason to backport JDK-8333200 to jdk17 and jdk11 also.

I think we should close this backport PR. Apologize for the interrupt. And thanks for the analysis @franferrax

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

2 participants