-
Notifications
You must be signed in to change notification settings - Fork 251
8350813: Rendering of bulky sound bank from MIDI sequence can cause OutOfMemoryError #3099
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
👋 Welcome back rmarchenko! A progress list of the required criteria for merging this PR into |
@wkia This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 77 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. ➡️ To flag this PR as ready for integration with the above commit message, type |
This backport pull request has now been updated with issue from the original commit. |
|
/approval request I'd like to backport this as the problem also exists in jdk11. This is almost clean backport, resolved conflict in copyright. Test fails before the fix, and passes with the fix. |
The build failures for s390x and ppc64le don't loook related to the changes. Infrastructure issues. |
@wkia This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a |
/touch |
@wkia The pull request is being re-evaluated and the inactivity timeout has been reset. |
This is backport of "JDK-8350813 Rendering of bulky sound bank from MIDI sequence can cause OutOfMemoryError"
The problem exists in jdk11 also.
Almost clean backport, resolved conflict in copyright.
Test fails before the fix, and passes with the fix.
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/3099/head:pull/3099
$ git checkout pull/3099
Update a local copy of the PR:
$ git checkout pull/3099
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/3099/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 3099
View PR using the GUI difftool:
$ git pr show -t 3099
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/3099.diff
Using Webrev
Link to Webrev Comment