-
Notifications
You must be signed in to change notification settings - Fork 250
8286562: GCC 12 reports some compiler warnings #3091
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
👋 Welcome back zzambers! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
This backport pull request has now been updated with issue from the original commit. |
/issue add JDK-8293691 |
@zzambers |
@zzambers This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a |
/touch |
@zzambers The pull request is being re-evaluated and the inactivity timeout has been reset. |
Backport fixes few warnings in newer gcc (12+), which I have seen some when doing test build for gcc15 (fedora 42) for another backport. Warning do not show in current GHA runs because it uses gcc 10. (Btw this change has also been backported to oracle jdk 11.)
Backport is not clear, there were some differences in surrounding context, copyright headers, location of gmk file etc. So part of it had to be done manually. Changes to jfrTraceIdBits.inline.hpp are not present, because modified function is not present on jdk11.
I also included backport of followup change (JDK-8293691), which fixes problem introduced by original backported change.
GHA tests: OK
Progress
Warning
8293691: converting a defined BasicType value to a string should not crash the VM
Issues
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/3091/head:pull/3091
$ git checkout pull/3091
Update a local copy of the PR:
$ git checkout pull/3091
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/3091/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 3091
View PR using the GUI difftool:
$ git pr show -t 3091
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/3091.diff
Using Webrev
Link to Webrev Comment