8298783: java/lang/ref/FinalizerHistogramTest.java failed with "RuntimeException: MyObject is not found in test output"

[sendaoYan]

Hi all,

This pull request contains a backport of commit fe29cad5 from the openjdk/jdk repository.

The commit being backported was authored by Brent Christian on 6 May 2025 and was reviewed by Kim Barrett and Jaikiran Pai.

This PR is intend to fix the test bug which cause test intermittent fails. Backport not clean because the path of sun.hotspot.WhiteBox different to main-line, the path should adopt to jdk11u-dev when backport from main-line to jdk11u-dev, Other parts is cleanly.

I have verified this backport plus with #3105.

Thanks!

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8298783 needs maintainer approval

Issue

• JDK-8298783: java/lang/ref/FinalizerHistogramTest.java failed with "RuntimeException: MyObject is not found in test output" (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/3074/head:pull/3074
$ git checkout pull/3074

Update a local copy of the PR:
$ git checkout pull/3074
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/3074/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3074

View PR using the GUI difftool:
$ git pr show -t 3074

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/3074.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

⚠️ @sendaoYan This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[mlbridge]

Webrevs

• 02: Full - Incremental (6c1eca29)
• 01: Full - Incremental (254938b2)
• 00: Full (1126ef57)

[bridgekeeper]

@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[sendaoYan]

/approval request Clean backport to make test more robustness which fix the test fails intermittent. Change has been verifiled locally on linux-x64. Test-fix only, risk is low.

[openjdk]

@sendaoYan
8298783: The approval request has been created successfully.

[bridgekeeper]

@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[sendaoYan]

I think we should backport JDK-8305186 first.

[sendaoYan]

The patch different to mainline:

diff --git a/test/jdk/java/lang/ref/FinalizerHistogramTest.java b/test/jdk/java/lang/ref/FinalizerHistogramTest.java
index 192c229c7b5..4dcea55b1f4 100644
--- a/test/jdk/java/lang/ref/FinalizerHistogramTest.java
+++ b/test/jdk/java/lang/ref/FinalizerHistogramTest.java
@@ -21,7 +21,7 @@
  * questions.
  */
 
-import jdk.test.whitebox.WhiteBox;
+import sun.hotspot.WhiteBox;
 
 import java.util.concurrent.atomic.AtomicInteger;
 import java.util.concurrent.locks.ReentrantLock;
@@ -34,8 +34,8 @@ import java.lang.reflect.Field;
  * @summary Unit test for FinalizerHistogram
  * @modules java.base/java.lang.ref:open
  * @library /test/lib
- * @build jdk.test.whitebox.WhiteBox
- * @run driver jdk.test.lib.helpers.ClassFileInstaller jdk.test.whitebox.WhiteBox
+ * @build sun.hotspot.WhiteBox
+ * @run driver ClassFileInstaller sun.hotspot.WhiteBox
  * @run main/othervm
  *      -Xbootclasspath/a:.
  *      -XX:+UnlockDiagnosticVMOptions

[sendaoYan]

/approval cancel

[openjdk]

@sendaoYan
8298783: The approval request has been cancelled successfully.