8372802: PrintFlagsFinal should also print locked flags

[fthevenet]

This change aims to provide a way to print all flags including "locked" ones (e.g. Diagnostic and Experimental) without having to explicitly set +UnlockExperimentalVMOptions or +UnlockDiagnosticVMOptions

This applies to the following VM options: PrintFlagsFinal , PrintFlagsRanges, PrintFlagsInitial, PrintFlagsWithComments, -XprintFlags, as well as the PrintVMFlagsDCmd diagnostic command (when set to show all flags).

Places that print out only flags that have been changed (i.e. that skip flags with default values), like when during the generation of hs_err reports, are not affected by this.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8372802: PrintFlagsFinal should also print locked flags (Enhancement - P4)

Reviewers

• Leonid Mesnik (@lmesnik - Reviewer) Review applies to 96ce8390
• David Holmes (@dholmes-ora - Reviewer)
• Thomas Stuefe (@tstuefe - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28579/head:pull/28579
$ git checkout pull/28579

Update a local copy of the PR:
$ git checkout pull/28579
$ git pull https://git.openjdk.org/jdk.git pull/28579/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28579

View PR using the GUI difftool:
$ git pr show -t 28579

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28579.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back fthevenet! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@fthevenet This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8372802: PrintFlagsFinal should also print locked flags

Reviewed-by: dholmes, stuefe, lmesnik

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 93 new commits pushed to the master branch:

• 63a10e0: 8373024: JFR: CPU throttle rate can't handle incorrect values
• 828498c: 8371978: tools/jar/ReproducibleJar.java fails on XFS
• dbf0742: 8373046: Method::get_c2i_unverified_entry() and get_c2i_no_clinit_check_entry() are missing check for abstract method
• ... and 90 more: https://git.openjdk.org/jdk/compare/160148cc7b0c2774e7aa5fece653e41c9fa7c970...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@lmesnik, @dholmes-ora, @tstuefe) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

@fthevenet The following label will be automatically applied to this pull request:

• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 03: Full - Incremental (975a7243)
• 02: Full - Incremental (3d22c0a2)
• 01: Full - Incremental (6cdac8e1)
• 00: Full (96ce8390)

[dholmes-ora]

I think this seems reasonable.

Have you run all of the tests that use this flag to check that the extra output does not cause any problems (e.g. if jtreg elides sections of the log because it is too long now)?

[fthevenet]

Have you run all of the tests that use this flag to check that the extra output does not cause any problems (e.g. if jtreg elides sections of the log because it is too long now)?

In addition to running tier1 on GHA, I also explicitly ran the tests that matched the following:

find ./test -type f -name "*.java" -exec grep -l -e "-XX:+PrintFlagsFinal" -e "-XX:+PrintFlagsInitial" -e "-XX:+PrintFlagsWithComments" -e "PrintVMFlagsDCmd" {} +

Hopefully that caught them all.

[fthevenet]

@tstuefe I've reworked the test a bit as you suggested. It's not much shorter but it does a better job at conveying the test's logic at a glance, I think.

[tstuefe]

Thanks!

[fthevenet]

/integrate

[openjdk]

@fthevenet
Your change (at version 975a724) is now ready to be sponsored by a Committer.

[dholmes-ora]

Update looks fine.

[dholmes-ora]

/sponsor

[openjdk]

Going to push as commit 771253e.
Since your change was applied there have been 93 commits pushed to the master branch:

• 63a10e0: 8373024: JFR: CPU throttle rate can't handle incorrect values
• 828498c: 8371978: tools/jar/ReproducibleJar.java fails on XFS
• dbf0742: 8373046: Method::get_c2i_unverified_entry() and get_c2i_no_clinit_check_entry() are missing check for abstract method
• ... and 90 more: https://git.openjdk.org/jdk/compare/160148cc7b0c2774e7aa5fece653e41c9fa7c970...master

Your commit was automatically rebased without conflicts.

[openjdk]

@dholmes-ora @fthevenet Pushed as commit 771253e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[fthevenet]

Thanks, @dholmes-ora