8179918: EnumSet spliterator should report SORTED, ORDERED, NONNULL #28568
+7
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the Spliterator for EnumSet does not report SORTED, ORDERED, or NONNULL characteristics, all of which are inherent to API of EnumSet. I found there's an existing ticket for this as well.
The ticket also mentions optimized
forEach, etc, which I presume means avoiding the default implementation that uses the iterator and just iterating over the bitset directly; I can add that here or perhaps in a follow up if it's still deemed worthwhile.Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28568/head:pull/28568$ git checkout pull/28568Update a local copy of the PR:
$ git checkout pull/28568$ git pull https://git.openjdk.org/jdk.git pull/28568/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 28568View PR using the GUI difftool:
$ git pr show -t 28568Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28568.diff
Using Webrev
Link to Webrev Comment