8319158: Parallel: Make TestObjectTenuringFlags use createTestJavaProcessBuilder #28567
+4
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of change:
executeLimitedTestJava changed to executeTestJava to allow flags to be propagated to forked processes.
@requires condition is expanded to include flags used in the test so that external flag settings don't disturb them.
Testing:
HS Tiers 1 and 2
Ran with all flag combinations in CI
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28567/head:pull/28567$ git checkout pull/28567Update a local copy of the PR:
$ git checkout pull/28567$ git pull https://git.openjdk.org/jdk.git pull/28567/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 28567View PR using the GUI difftool:
$ git pr show -t 28567Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28567.diff
Using Webrev
Link to Webrev Comment