8372755: Remove local suppression of VS C4146 warnings

[kimbarrett]

Please review this trivial change to remove unnecessary local Visual Studio
warning suppressions for C4146 in HotSpot code. JDK-8254072 intentionally
globally suppressed that warning when building HotSpot, so local suppression
is no longer needed.

Testing: mach5 tier1

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8372755: Remove local suppression of VS C4146 warnings (Enhancement - P4)

Reviewers

• Albert Mingkun Yang (@albertnetymk - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28564/head:pull/28564
$ git checkout pull/28564

Update a local copy of the PR:
$ git checkout pull/28564
$ git pull https://git.openjdk.org/jdk.git pull/28564/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28564

View PR using the GUI difftool:
$ git pr show -t 28564

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28564.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back kbarrett! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@kimbarrett This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8372755: Remove local suppression of VS C4146 warnings

Reviewed-by: ayang

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 28 new commits pushed to the master branch:

• fd7283b: 8360046: Scalability issue when submitting virtual threads with almost empty tasks
• 3f046f6: 8372747: G1: Conservative heap alignment does not account for card table constraint
• e27abe8: 8372540: SerialGC: Remove race between allocation and expansion before is_init_completed
• ... and 25 more: https://git.openjdk.org/jdk/compare/92e1357dfd2d874ef1a62ddd69c86a7bb189c6a2...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@kimbarrett The following label will be automatically applied to this pull request:

• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (551b3b2c)

[albertnetymk]

Trivial.

[kimbarrett]

Thanks for reviewing @albertnetymk .

[kimbarrett]

/integrate

[openjdk]

Going to push as commit 6f2169f.
Since your change was applied there have been 36 commits pushed to the master branch:

• c97d53a: 8371470: Java Launcher does not fail when running compact java-file with private no-arg constructor
• 6c01d3b: 8372451: C2 SuperWord: "endless loop" assert. Need to implement proper worklist mechanism
• eecba58: 8371587: Final mapping lost in ProcSmapsParser::parse_next
• ... and 33 more: https://git.openjdk.org/jdk/compare/92e1357dfd2d874ef1a62ddd69c86a7bb189c6a2...master

Your commit was automatically rebased without conflicts.

[openjdk]

@kimbarrett Pushed as commit 6f2169f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.