8372738: ZGC: C2 allocation reloc promotion deopt race

[fisk]

In https://bugs.openjdk.org/browse/JDK-8371200 a race was handled between flip promoting objects, their promotion barriers, tenuring threshold selection and signalling to the JIT slow path allocation code to deoptimize. It made sure that flip promoted objects are made old before a handshake with the Java threads, and ran promotion barriers to erase any raw nulls after the handshake. This order was crucial to the fix.

Now unfortunately, there is a related problem for relocate promoting objects. Such objects run the promotion barriers before the object becomes old, which is the signal for the JIT allocation slow path code to deopt. Unfortunately, the order should be the opposite, similar to flip promoted objects. I propose signalling that relocate promoting pages are marked as relocate promoted during relocation set selection, and include that as a condition for deopt in the allocation slow path. The relocation set selection runs before the handshake, hence ensuring that promotion barriers won't race with JIT compiled code that has elided barriers.

T1-5 tests look good. The test that failed before reproduces an observable issue without the fix and not after the fix.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8372738: ZGC: C2 allocation reloc promotion deopt race (Bug - P2)

Reviewers

• Axel Boldt-Christmas (@xmas92 - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28558/head:pull/28558
$ git checkout pull/28558

Update a local copy of the PR:
$ git checkout pull/28558
$ git pull https://git.openjdk.org/jdk.git pull/28558/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28558

View PR using the GUI difftool:
$ git pr show -t 28558

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28558.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back eosterlund! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@fisk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8372738: ZGC: C2 allocation reloc promotion deopt race

Reviewed-by: aboldtch

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 17 new commits pushed to the master branch:

• 5bd7db0: 8372730: Problem list compiler/arguments/TestCodeEntryAlignment.java on x64
• 3481252: 8372188: AArch64: Generate atomic match rules from M4 stencils
• ef5e744: 8372684: G1: Missing load_acquire() in G1 allocation path
• ... and 14 more: https://git.openjdk.org/jdk/compare/0021dc04100befd107d3aa763510b28dd62cd62c...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@fisk The following label will be automatically applied to this pull request:

• hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[xmas92]

Looks good. A lot nice to have all the promotion barriers in one place.

[xmas92]

Could use the fancy new Atomic<bool>. But I am currently working on a patch to migrate all our volatile + AtomicAccess to Atomic, so I think we can leave it using the old style for now.

[mlbridge]

Webrevs

• 00: Full (e0bf6f4e)