8372588: [asan] serviceability/sa/TestJmapCore.java and TestJmapCoreMetaspace.java fail after recent improvements

[MBaesken]

In the 2 core related tests TestJmapCore.java and TestJmapCoreMetaspace.java we run into the errors below when using asan-enabled binaries. This is most likely because we do not write cores any more with asan; seems to be related to JDK-8368365 .

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8372588: [asan] serviceability/sa/TestJmapCore.java and TestJmapCoreMetaspace.java fail after recent improvements (Bug - P4)

Reviewers

• Thomas Stuefe (@tstuefe - Reviewer)
• Arno Zeller (@ArnoZeller - Author)
• Lutz Schmidt (@RealLucy - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28552/head:pull/28552
$ git checkout pull/28552

Update a local copy of the PR:
$ git checkout pull/28552
$ git pull https://git.openjdk.org/jdk.git pull/28552/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28552

View PR using the GUI difftool:
$ git pr show -t 28552

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28552.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@MBaesken This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8372588: [asan] serviceability/sa/TestJmapCore.java and TestJmapCoreMetaspace.java fail after recent improvements

Reviewed-by: stuefe, azeller, lucy

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 10 new commits pushed to the master branch:

• e071afb: 8351334: [ubsan] memoryReserver.cpp:552:60: runtime error: applying non-zero offset 1073741824 to null pointer
• 78b155b: 8372147: ConnectionFlowControlTest should use HttpResponse.connectionLabel()
• 08c16c3: 8372704: ThreadMXBean.getThreadUserTime may return total time
• ... and 7 more: https://git.openjdk.org/jdk/compare/683ef14bcec0e6c4825067229826ed4a53cd3d19...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@MBaesken The following label will be automatically applied to this pull request:

• serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (1a3145c4)

[tstuefe]

Okay

[ArnoZeller]

Looks good to me.

[RealLucy]

Looks good.

[MBaesken]

Thanks for the reviews !

/integrate

[openjdk]

Going to push as commit a6bc9b3.
Since your change was applied there have been 19 commits pushed to the master branch:

• 293fec7: 8372461: [IR Framework] Multiple test failures after JDK-8371789
• ca96366: 8372528: Unify atomic exchange and compare exchange
• 81b26ba: 8372685: C2 SuperWord: wrong requires in test after JDK-8371146
• ... and 16 more: https://git.openjdk.org/jdk/compare/683ef14bcec0e6c4825067229826ed4a53cd3d19...master

Your commit was automatically rebased without conflicts.

[openjdk]

@MBaesken Pushed as commit a6bc9b3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.