6223700: XP L&F: Non-TopLevel JMenu's painting error

[prsadhuk]

It is seen that non-TopLevel JMenu's get repainted when the mouse exits the item. If the popup menu is still visible to the right, repainting the JMenu causes the selection background to be repainted over the top of the popup, even though the popup is supposed to appear above the JMenu.

The problem is caused by the mouse handling code in the protected inner class WindowsMenuUI.WindowsMouseInputHandler. The mouseEntered and mouseExited handlers set the RollOver property and the JMenu gets repainted. However, setting the RollOver property is only necessary for top-level JMenus. Non-TopLevel JMenu menu items such as these get painted by the super class BasicMenuItemUI which uses isSelected() rather than isRollOver() to determine whether the selection background color should be used.

Fix is to use the repainting only for TopLevel Menu in mouseExited, the same way it is being done for mouseEntered

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-6223700: XP L&F: Non-TopLevel JMenu's painting error (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28551/head:pull/28551
$ git checkout pull/28551

Update a local copy of the PR:
$ git checkout pull/28551
$ git pull https://git.openjdk.org/jdk.git pull/28551/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28551

View PR using the GUI difftool:
$ git pr show -t 28551

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28551.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back psadhukhan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[openjdk]

@prsadhuk The following label will be automatically applied to this pull request:

• client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (15ffec66)