8371194: serviceability/sa/TestJhsdbJstackMixedWithXComp.java failing

[YaSuenag]

We've fixed mixed mode jstack for the debuggee running with -Xcomp in JDK-8370176, but it was not enough. We need to handle like unifying CFrame and Frame in stack unwinding as possible, and need to change how to get caller SP/FP from stack.

This PR works fine on both Linux AMD64 and Linux AArch64. All of hotspot/jtreg/serviceability/sa tests have been passed on both platforms.

Big thanks to @pchilano for your help!

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8371194: serviceability/sa/TestJhsdbJstackMixedWithXComp.java failing (Bug - P4)

Reviewers

• Patricio Chilano Mateo (@pchilano - Reviewer)

Contributors

• Patricio Chilano Mateo <[email protected]>

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28284/head:pull/28284
$ git checkout pull/28284

Update a local copy of the PR:
$ git checkout pull/28284
$ git pull https://git.openjdk.org/jdk.git pull/28284/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28284

View PR using the GUI difftool:
$ git pr show -t 28284

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28284.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back ysuenaga! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@YaSuenag This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8371194: serviceability/sa/TestJhsdbJstackMixedWithXComp.java failing

Co-authored-by: Patricio Chilano Mateo <[email protected]>
Reviewed-by: pchilanomate

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 64 new commits pushed to the master branch:

• e5f6332: 8371650: Add CMakeLists.txt and compile_commands.json into .gitignore
• 6c09529: 8369188: Update link-time check for HotSpot uses of allocation and deallocation functions
• 9ec773a: 8371689: (fs) CopyMoveHelper.copyToForeignTarget use of sourcePosixView is confusing
• ... and 61 more: https://git.openjdk.org/jdk/compare/279f39f14a6329d0147613edc3836b7d6d043186...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@YaSuenag The following label will be automatically applied to this pull request:

• serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[YaSuenag]

/contributor add @pchilano

[openjdk]

@YaSuenag
Contributor Patricio Chilano Mateo <[email protected]> successfully added.

[mlbridge]

Webrevs

• 01: Full - Incremental (dfd947ab)
• 00: Full (4b854cd5)

[YaSuenag]

This PR is for Linux, other platforms (Windows, Mac) would not work. However I think it is not a problem because Windows and Mac has not been supported mixed jstack originally.

[pchilano]

Fix looks good to me (can't comment on the PPC and RISCV parts though).

[pchilano]

Can't we run the test on AArch64 now?

[YaSuenag]

I think this PR works on Linux AArch64, but I'm not sure because previous change (#27885) worked on some Linux AArch64, but there are some platforms whch did not work. Thus I think it is better to keep this test for Linux AMD64 only.

I couldn't reproduce the problem on Fedora Rawhide on Raspberry Pi 4, but there might be some issue because SA does not have DWARF parser for AArch 64 - it means the native we cannot find sender frame which depends on DWARF, does not use FP as frame pointer.

[plummercj]

I enabled this test for linux-aarch64 and it seems to pass our testing.

[YaSuenag]

I saw the problem on VMError::report_and_die because its frame could not be unwinded without DWARF.

I have not seen the problem in other place, but I'm concerned the test fails on some Linux AArch64 platforms. Thus I think it is better to wait enabling the test until SA supports DWARF.