Closes #120 #121
Open
Closes #120 #121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dstenger
suggested changes
Apr 3, 2025
| // will return an URL | ||
| return resource; | ||
| } | ||
| System.out.println(resource); |
There was a problem hiding this comment.
Can you please remove the System.out?
| * @return A File object, or null if one could not be created. | ||
| */ | ||
| final File findScriptFile(URI uri) { | ||
| final Object findScriptFile(URI uri) { |
There was a problem hiding this comment.
Can you please check if a more specific data type can be used?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #120
Depends on opengeospatial/teamengine#634