-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
more .h includes simplification #8187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
good to go. should we re-add includes in ofMain.h to keep all of them available ? |
|
I've brought this PR to be compatible with master |
|
Thanks @dimitre - have you benchmarked the compile time difference with this change and without? Generally ofConstants.h is where these things are meant to live, so moving to ofMain.h would only make sense if we can see a big speed up. Thanks! |
|
@ofTheo I didnt think it would make much differente but in fact if we compare the runners in this one against another normal PR like this we see improvement in compile times in all runners. sometimes less than 50% original time. https://github.com/openframeworks/openFrameworks/pull/8187/checks This PR removes lots of unneeded system includes (sometimes they are huge) so compiler has much less lines to process |
|
@dimitre wow, yes, I see the difference too! Seems worth it for the speed up alone and people typically include ofMain.h so seems fairly safe |
This PR removes some includes from ofConstants.h and include by demand where needed.
includes are:
We can add them to ofMain.h to assure they are still added on projects
Linux action runner is failing because of libgconf-2-4