remove OF_NO_FMOD #8184
Open
remove OF_NO_FMOD #8184
+107
−198
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Looks awesome!! |
Member
Author
|
I think this one is finally ok! |
dimitre
added a commit
to dimitre/openFrameworks
that referenced
this pull request
Nov 18, 2025
ofTheo
reviewed
Nov 19, 2025
| #define OF_CAIRO | ||
| #define OF_RTAUDIO | ||
| #ifndef __MACOSX_CORE__ | ||
| #define __MACOSX_CORE__ // rtAudio |
Member
There was a problem hiding this comment.
Safe to remove even though it mentions rtAudio?
ofTheo
reviewed
Nov 19, 2025
ofTheo
reviewed
Nov 19, 2025
| HEADER_SSL = $(OF_PATH)/libs/openssl/include | ||
| HEADER_URIPARSER = $(OF_PATH)/libs/uriparser/include | ||
| HEADER_PUGIXML = $(OF_PATH)/libs/pugixml/include | ||
|
|
Member
There was a problem hiding this comment.
Curious about the quote removal - is there any downside to removing?
Member
|
A big one!! Thanks @dimitre !!!!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As FMOD is not the default player anymore we can remove the logic for this define and keep only USE_FMOD
Quicktime and QTkit removal
Boost references removal (not on apothecary anymore)
Some intermediate ways of making FMOD work if needed, as a transition period.
Project.xcconfig tidy up