Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR introduces a shared i18n translator type in src/common and uses it to type the replaceBodyTemplateVariables helper, then re-exports the new type from the package entrypoint.
Changes:
- Add
I18nIinterface (witht(key: string): string) undersrc/common. - Update message template variable replacement to accept
i18n: I18nIinstead of an inline structural type. - Re-export
I18nIfromsrc/common/index.tsandsrc/index.ts.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/message/messages.ts | Switches replaceBodyTemplateVariables to use the shared I18nI type. |
| src/index.ts | Re-exports I18nI from the public package entrypoint. |
| src/common/index.ts | Adds a barrel export for I18nI. |
| src/common/i18nI.ts | Introduces the new i18n translator interface. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.