expressions: fixed dependent nodes evaluation inside single entities#348
Merged
expressions: fixed dependent nodes evaluation inside single entities#348
Conversation
There was a problem hiding this comment.
Pull request overview
This PR targets correctness of expression/identifier resolution in record updates, specifically to improve dependent node evaluation within single-entity contexts.
Changes:
- Adjusted common-ancestor detection when resolving referenced nodes in record identifier expressions.
- Refactored several iterations from
forEach/reducetofor...ofloops in record update and identifier evaluation paths. - Added extra error context (
details) when wrapping an ancestor lookup failure.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/record/recordNodesUpdater/recordNodesUpdater.ts | Refactors dependent-def node collection to for...of iteration. |
| src/record/recordExpressionEvaluator/node/identifier/nodesFinder.ts | Updates common-ancestor hierarchy comparison used to locate referenced nodes. |
| src/record/recordExpressionEvaluator/node/identifier/identifier.ts | Improves error payload for ancestor lookup and refactors array-context identifier evaluation loop. |
| src/nodeDefExpressionEvaluator/node/identifier.ts | Refactors reachable node-def collection to for...of during traversal (including single entities). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/record/recordExpressionEvaluator/node/identifier/nodesFinder.ts
Outdated
Show resolved
Hide resolved
src/record/recordExpressionEvaluator/node/identifier/identifier.ts
Outdated
Show resolved
Hide resolved
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.