Skip to content

Use getDisplayMetrics() to find screen DPI on Android. #1604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
player-03 merged 3 commits into from
Apr 16, 2023
Merged

Use getDisplayMetrics() to find screen DPI on Android. #1604

player-03 merged 3 commits into from
Apr 16, 2023

Conversation

@MAJigsaw77
Copy link
Contributor

@MAJigsaw77 MAJigsaw77 commented Nov 25, 2022

Title

@player-03
Copy link
Contributor

player-03 commented Nov 26, 2022

I'd say it's safe to use getRealMetrics() without checking. JELLY_BEAN_MR1 corresponds to SDK 17, and as of #1519, Lime is no longer compatible with SDKs below 21. Plus, Google dropped support for that version in September 2021.

@MAJigsaw77
Copy link
Contributor Author

MAJigsaw77 commented Nov 27, 2022

A ok

@MAJigsaw77
Copy link
Contributor Author

MAJigsaw77 commented Nov 27, 2022

@player-03 done

@player-03
Use getDisplayMetrics().
61dd062 
`getRealMetrics()` is now deprecated as well. It suggests using `getCurrentWindowMetrics()` instead, but that's new in SDK 30 and doesn't even contain DPI information. Whereas this function has been around since the start.
@player-03 player-03 changed the title Using Display RealMetrics when supported on android. Use getRealMetrics() to find screen DPI on Android. Dec 20, 2022
@player-03 player-03 changed the title Use getRealMetrics() to find screen DPI on Android. Use getDisplayMetrics() to find screen DPI on Android. Dec 20, 2022
@MAJigsaw77 MAJigsaw77 closed this by deleting the head repository Mar 5, 2023
@player-03 player-03 reopened this Mar 5, 2023
@MAJigsaw77
Copy link
Contributor Author

MAJigsaw77 commented Mar 5, 2023

I thought this won't be pushed, that's why I closed it .___.

@dimensionscape
Copy link
Member

dimensionscape commented Mar 5, 2023

I haven't looked at it personally yet, but sometimes it just takes us forever to completely vet some prs. If you're getting feedback, its typically a good sign.

@MAJigsaw77
Copy link
Contributor Author

MAJigsaw77 commented Mar 5, 2023

Ok

@player-03 player-03 merged commit ee4bcb5 into openfl:develop Apr 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MAJigsaw77 @player-03 @dimensionscape