-
Notifications
You must be signed in to change notification settings - Fork 5
feat: add course authoring migration and rollback scripts #218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dwong2708
wants to merge
10
commits into
openedx:main
Choose a base branch
from
WGU-Open-edX:dwong2708/migration-script-for-course-roles
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
724662c
feat: add course authoring migration and rollback scripts
dwong2708 bf5d76c
fixup! feat: add course authoring migration and rollback scripts
dwong2708 ac7acef
fixup! feat: add course authoring migration and rollback scripts
dwong2708 e627dd7
fixup! feat: add course authoring migration and rollback scripts
dwong2708 ec9785f
fixup! feat: add course authoring migration and rollback scripts
dwong2708 1cda364
fixup! feat: add course authoring migration and rollback scripts
dwong2708 c8f1c73
fixup! feat: add course authoring migration and rollback scripts
dwong2708 37149a8
fixup! feat: add course authoring migration and rollback scripts
dwong2708 1753f8e
fixup! feat: add course authoring migration and rollback scripts
dwong2708 0a21eb5
fixup! feat: add course authoring migration and rollback scripts
dwong2708 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -8,14 +8,29 @@ | |
|
|
||
| from casbin import Enforcer | ||
|
|
||
| from openedx_authz.api.users import assign_role_to_user_in_scope, batch_assign_role_to_users_in_scope | ||
| from openedx_authz.constants.roles import LIBRARY_ADMIN, LIBRARY_AUTHOR, LIBRARY_USER | ||
| from openedx_authz.api.data import CourseOverviewData | ||
| from openedx_authz.api.users import ( | ||
| assign_role_to_user_in_scope, | ||
| batch_assign_role_to_users_in_scope, | ||
| batch_unassign_role_from_users, | ||
| get_user_role_assignments, | ||
| ) | ||
| from openedx_authz.constants.roles import ( | ||
| LEGACY_COURSE_ROLE_EQUIVALENCES, | ||
| LIBRARY_ADMIN, | ||
| LIBRARY_AUTHOR, | ||
| LIBRARY_USER, | ||
| ) | ||
|
|
||
| logger = logging.getLogger(__name__) | ||
|
|
||
| GROUPING_POLICY_PTYPES = ["g", "g2", "g3", "g4", "g5", "g6"] | ||
|
|
||
|
|
||
| # Map new roles back to legacy roles for rollback purposes | ||
| COURSE_ROLE_EQUIVALENCES = {v: k for k, v in LEGACY_COURSE_ROLE_EQUIVALENCES.items()} | ||
|
|
||
|
|
||
| def migrate_policy_between_enforcers( | ||
| source_enforcer: Enforcer, | ||
| target_enforcer: Enforcer, | ||
|
|
@@ -151,3 +166,169 @@ def migrate_legacy_permissions(ContentLibraryPermission): | |
| ) | ||
|
|
||
| return permissions_with_errors | ||
|
|
||
|
|
||
| def migrate_legacy_course_roles_to_authz(CourseAccessRole, course_id_list, org_id, delete_after_migration): | ||
| """ | ||
| Migrate legacy course role data to the new Casbin-based authorization model. | ||
| This function reads legacy permissions from the CourseAccessRole model | ||
| and assigns equivalent roles in the new authorization system. | ||
|
|
||
| The old Course permissions are stored in the CourseAccessRole model, it consists of the following columns: | ||
|
|
||
| - user: FK to User | ||
| - org: optional Organization string | ||
| - course_id: optional CourseKeyField of Course | ||
| - role: 'instructor' | 'staff' | 'limited_staff' | 'data_researcher' | ||
|
|
||
| In the new Authz model, this would roughly translate to: | ||
|
|
||
| - course_id: scope | ||
| - user: subject | ||
| - role: role | ||
|
|
||
| param CourseAccessRole: The CourseAccessRole model to use. | ||
| """ | ||
| if not course_id_list and not org_id: | ||
| raise ValueError( | ||
| "At least one of course_id_list or org_id must be provided to limit the scope of the rollback migration." | ||
| ) | ||
| course_access_role_filter = { | ||
| "course_id__startswith": "course-v1:", | ||
| } | ||
|
|
||
| if org_id: | ||
| course_access_role_filter["org"] = org_id | ||
|
|
||
| if course_id_list and not org_id: | ||
| # Only filter by course_id if org_id is not provided, | ||
| # otherwise we will filter by org_id which is more efficient | ||
| course_access_role_filter["course_id__in"] = course_id_list | ||
|
|
||
| legacy_permissions = CourseAccessRole.objects.filter(**course_access_role_filter).select_related("user").all() | ||
|
|
||
| # List to keep track of any permissions that could not be migrated | ||
| permissions_with_errors = [] | ||
| permissions_with_no_errors = [] | ||
|
|
||
| for permission in legacy_permissions: | ||
| # Migrate the permission to the new model | ||
|
|
||
| role = LEGACY_COURSE_ROLE_EQUIVALENCES.get(permission.role) | ||
| if role is None: | ||
| # This should not happen as there are no more access_levels defined | ||
| # in CourseAccessRole, log and skip | ||
| logger.error(f"Unknown access level: {permission.role} for User: {permission.user}") | ||
| permissions_with_errors.append(permission) | ||
| continue | ||
|
|
||
| # Permission applied to individual user | ||
| logger.info( | ||
| f"Migrating permission for User: {permission.user.username} " | ||
| f"to Role: {role} in Scope: {permission.course_id}" | ||
| ) | ||
|
|
||
| is_user_added = assign_role_to_user_in_scope( | ||
| user_external_key=permission.user.username, | ||
| role_external_key=role, | ||
| scope_external_key=str(permission.course_id), | ||
| ) | ||
|
|
||
| if not is_user_added: | ||
| logger.error( | ||
| f"Failed to migrate permission for User: {permission.user.username} " | ||
| f"to Role: {role} in Scope: {permission.course_id}" | ||
| ) | ||
| permissions_with_errors.append(permission) | ||
| continue | ||
|
|
||
| permissions_with_no_errors.append(permission) | ||
|
|
||
| if delete_after_migration: | ||
| # Only delete permissions that were successfully migrated to avoid data loss. | ||
| CourseAccessRole.objects.filter(id__in=[p.id for p in permissions_with_no_errors]).delete() | ||
|
|
||
| return permissions_with_errors, permissions_with_no_errors | ||
|
|
||
|
|
||
| def migrate_authz_to_legacy_course_roles(CourseAccessRole, UserSubject, course_id_list, org_id, delete_after_migration): | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same thing as above with these names |
||
| """ | ||
| Migrate permissions from the new Casbin-based authorization model back to the legacy CourseAccessRole model. | ||
| This function reads permissions from the Casbin enforcer and creates equivalent entries in the | ||
| CourseAccessRole model. | ||
|
|
||
| This is essentially the reverse of migrate_legacy_course_roles_to_authz and is intended | ||
| for rollback purposes in case of migration issues. | ||
| """ | ||
| if not course_id_list and not org_id: | ||
| raise ValueError( | ||
| "At least one of course_id_list or org_id must be provided to limit the scope of the rollback migration." | ||
| ) | ||
|
|
||
| # 1. Get all users with course-related permissions in the new model by filtering | ||
| # UserSubjects that are linked to CourseScopes with a valid course overview. | ||
| course_subject_filter = { | ||
| "casbin_rules__scope__coursescope__course_overview__isnull": False, | ||
| } | ||
|
|
||
| if org_id: | ||
| course_subject_filter["casbin_rules__scope__coursescope__course_overview__org"] = org_id | ||
|
|
||
| if course_id_list and not org_id: | ||
| # Only filter by course_id if org_id is not provided, | ||
| # otherwise we will filter by org_id which is more efficient | ||
| course_subject_filter["casbin_rules__scope__coursescope__course_overview__id__in"] = course_id_list | ||
|
|
||
| course_subjects = UserSubject.objects.filter(**course_subject_filter).select_related("user").distinct() | ||
|
|
||
| roles_with_errors = [] | ||
| roles_with_no_errors = [] | ||
|
|
||
| for course_subject in course_subjects: | ||
| user = course_subject.user | ||
| user_external_key = user.username | ||
|
|
||
| # 2. Get all role assignments for the user | ||
| role_assignments = get_user_role_assignments(user_external_key=user_external_key) | ||
|
|
||
| for assignment in role_assignments: | ||
| if not isinstance(assignment.scope, CourseOverviewData): | ||
| logger.error(f"Skipping role assignment for User: {user_external_key} due to missing course scope.") | ||
| continue | ||
|
|
||
| scope = assignment.scope.external_key | ||
|
|
||
| course_overview = assignment.scope.get_object() | ||
dwong2708 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| for role in assignment.roles: | ||
| legacy_role = COURSE_ROLE_EQUIVALENCES.get(role.external_key) | ||
| if legacy_role is None: | ||
| logger.error(f"Unknown role: {role} for User: {user_external_key}") | ||
| roles_with_errors.append((user_external_key, role.external_key, scope)) | ||
| continue | ||
|
|
||
| try: | ||
| # Create legacy CourseAccessRole entry | ||
| CourseAccessRole.objects.get_or_create( | ||
| user=user, | ||
| org=course_overview.org, | ||
| course_id=scope, | ||
| role=legacy_role, | ||
| ) | ||
| roles_with_no_errors.append((user_external_key, role.external_key, scope)) | ||
| except Exception as e: # pylint: disable=broad-exception-caught | ||
| logger.error( | ||
| f"Error creating CourseAccessRole for User: " | ||
| f"{user_external_key}, Role: {legacy_role}, Course: {scope}: {e}" | ||
| ) | ||
| roles_with_errors.append((user_external_key, role.external_key, scope)) | ||
| continue | ||
|
|
||
| # If we successfully created the legacy role, we can unassign the new role | ||
| if delete_after_migration: | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. In the other direction we only do this on |
||
| batch_unassign_role_from_users( | ||
| users=[user_external_key], | ||
| role_external_key=role.external_key, | ||
| scope_external_key=scope, | ||
| ) | ||
| return roles_with_errors, roles_with_no_errors | ||
87 changes: 87 additions & 0 deletions
87
openedx_authz/management/commands/authz_migrate_course_authoring.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,87 @@ | ||
| """ | ||
| Django management command to migrate legacy course authoring roles to the new Authz (Casbin-based) authorization system. | ||
| """ | ||
|
|
||
| from django.core.management.base import BaseCommand, CommandError | ||
| from django.db import transaction | ||
|
|
||
| from openedx_authz.engine.utils import migrate_legacy_course_roles_to_authz | ||
|
|
||
| try: | ||
| from common.djangoapps.student.models import CourseAccessRole | ||
| except ImportError: | ||
| CourseAccessRole = None # type: ignore | ||
|
|
||
|
|
||
| class Command(BaseCommand): | ||
| """ | ||
| Django command to migrate legacy CourseAccessRole data | ||
| to the new Authz (Casbin-based) authorization system. | ||
| """ | ||
|
|
||
| help = "Migrate legacy course authoring roles to the new Authz system." | ||
|
|
||
| def add_arguments(self, parser): | ||
| parser.add_argument( | ||
| "--delete", | ||
| action="store_true", | ||
| help="Delete legacy CourseAccessRole records after successful migration.", | ||
| ) | ||
| parser.add_argument( | ||
| "--course-id-list", | ||
| nargs="*", | ||
| type=str, | ||
| help="Optional list of course IDs to filter the migration.", | ||
| ) | ||
|
|
||
| parser.add_argument( | ||
| "--org-id", | ||
| type=str, | ||
| help="Optional organization ID to filter the migration.", | ||
| ) | ||
|
|
||
| def handle(self, *args, **options): | ||
| delete_after_migration = options["delete"] | ||
| course_id_list = options.get("course_id_list") | ||
| org_id = options.get("org_id") | ||
|
|
||
| if not course_id_list and not org_id: | ||
| raise CommandError("You must specify either --course-id-list or --org-id to filter the rollback.") | ||
|
|
||
| if course_id_list and org_id: | ||
| raise CommandError("You cannot use --course-id-list and --org-id together.") | ||
|
|
||
| self.stdout.write(self.style.WARNING("Starting legacy → Authz migration...")) | ||
|
|
||
| try: | ||
| if delete_after_migration: | ||
| confirm = input( | ||
| "Are you sure you want to delete successfully migrated legacy roles? Type 'yes' to continue: " | ||
| ) | ||
|
|
||
| if confirm != "yes": | ||
| self.stdout.write(self.style.WARNING("Deletion aborted.")) | ||
| return | ||
| with transaction.atomic(): | ||
| errors, success = migrate_legacy_course_roles_to_authz( | ||
| CourseAccessRole=CourseAccessRole, | ||
| course_id_list=course_id_list, | ||
| org_id=org_id, | ||
| delete_after_migration=delete_after_migration, | ||
| ) | ||
|
|
||
| if errors: | ||
| self.stdout.write(self.style.ERROR(f"Migration completed with {len(errors)} errors.")) | ||
| else: | ||
| self.stdout.write( | ||
| self.style.SUCCESS(f"Migration completed successfully with {len(success)} roles migrated.") | ||
| ) | ||
|
|
||
| if delete_after_migration: | ||
| self.stdout.write(self.style.SUCCESS(f"{len(success)} Legacy roles deleted successfully.")) | ||
|
|
||
| except Exception as exc: | ||
| self.stdout.write(self.style.ERROR(f"Migration failed due to unexpected error: {exc}")) | ||
| raise | ||
|
|
||
| self.stdout.write(self.style.SUCCESS("Done.")) |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can see why
CourseAccessRoleis named that, but it's pretty confusing to read. Would you be ok renaming it to something likecourse_access_role_modeland putting a note in as to why we pass it this way?