Skip to content

Conversation

@mccalluc
Copy link
Contributor

The counts PR should be redone from scratch, since we decided it would be better to always do a DP count. That said, there are several other good changes in that PR that should be kept:

  • Weights enum strengthens our type signatures
  • Subsetting tests helps them run in a reasonable period of time.
  • Include a full path to the CSV fixture in generated code, so it can be run out of the box.

@github-project-automation github-project-automation bot moved this to Pending in DP Wizard Nov 24, 2025
@mccalluc mccalluc moved this from Pending to Ready for Review in DP Wizard Nov 25, 2025
Copy link
Member

@ekraffmiller ekraffmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@github-project-automation github-project-automation bot moved this from Ready for Review to Ready to Merge in DP Wizard Dec 10, 2025
@mccalluc mccalluc merged commit 252ff79 into main Dec 10, 2025
4 checks passed
@mccalluc mccalluc deleted the 643-useful-parts-of-count-pr branch December 10, 2025 14:55
@github-project-automation github-project-automation bot moved this from Ready to Merge to Complete in DP Wizard Dec 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Complete

Development

Successfully merging this pull request may close these issues.

3 participants