Skip to content

remove unneeded ".cast(float)" #735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mccalluc merged 1 commit into from
Dec 11, 2025
Merged

remove unneeded ".cast(float)" #735

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dp_wizard/utils/code_generators/analyses/mean/no-tests/_mean_expr.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# See the OpenDP Library docs for more on making private means:
# https://docs.opendp.org/en/OPENDP_V_VERSION/getting-started/tabular-data/essential-statistics.html#Mean

EXPR_NAME = pl.col(COLUMN_NAME).cast(float).dp.mean((LOWER_BOUND, UPPER_BOUND))
EXPR_NAME = pl.col(COLUMN_NAME).dp.mean((LOWER_BOUND, UPPER_BOUND))
6 changes: 3 additions & 3 deletions dp_wizard/utils/code_generators/analyses/median/no-tests/_median_expr.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@
# https://docs.opendp.org/en/OPENDP_V_VERSION/getting-started/tabular-data/essential-statistics.html#Median

EXPR_NAME = (
pl.col(COLUMN_NAME)
.cast(float)
.dp.quantile(0.5, make_cut_points(LOWER_BOUND, UPPER_BOUND, bin_count=BIN_COUNT))
pl.col(COLUMN_NAME).dp.quantile(
0.5, make_cut_points(LOWER_BOUND, UPPER_BOUND, bin_count=BIN_COUNT)
)
# Or use "dp.median" which provides 0.5 implicitly.
)
8 changes: 4 additions & 4 deletions tests/utils/test_code_generators.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ def test_make_column_config_block_for_mean():
== f"""# See the OpenDP Library docs for more on making private means:
# https://docs.opendp.org/en/v{opendp_version}/getting-started/tabular-data/essential-statistics.html#Mean

hw_grade_expr = pl.col('HW GRADE').cast(float).dp.mean((0, 100))"""
hw_grade_expr = pl.col('HW GRADE').dp.mean((0, 100))"""
)


Expand All @@ -70,9 +70,9 @@ def test_make_column_config_block_for_median():
# https://docs.opendp.org/en/v{opendp_version}/getting-started/tabular-data/essential-statistics.html#Median

hw_grade_expr = (
pl.col('HW GRADE')
.cast(float)
.dp.quantile(0.5, make_cut_points(0, 100, bin_count=20))
pl.col('HW GRADE').dp.quantile(
0.5, make_cut_points(0, 100, bin_count=20)
)
# Or use "dp.median" which provides 0.5 implicitly.
)""" # noqa: B950 (too long!)
)
Expand Down
Loading