Skip to content

optimize logo svg and set favicon (#501, #502) - #509

Merged
leoisadev1 merged 3 commits into
mainfrom
svg-favicon-optimization
Jan 16, 2026
Merged

optimize logo svg and set favicon (#501, #502)#509
leoisadev1 merged 3 commits into
mainfrom
svg-favicon-optimization

Conversation

@leoisadev1

Copy link
Copy Markdown
Member

Summary

This PR supersedes #503 to unblock CodeQL checks. The changes are identical.

Original PR by @gandandev:

  • Optimized logo.svg from 2289 bytes to 332 bytes (85% reduction) by replacing 28 individual <rect> elements with a single <path> element
  • Added SVG favicon link for modern browsers
  • Added manifest.json link for PWA support
  • Maintained backward compatibility with ICO fallback
  • Fixed icon order (SVG before ICO) as suggested by Greptile review

Closes #503

🤖 Generated with Claude Code

gandandev and others added 3 commits January 16, 2026 09:22
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
@railway-app

railway-app Bot commented Jan 16, 2026

Copy link
Copy Markdown

🚅 Deployed to the openchat-pr-509 environment in OpenChat

Service Status Web Updated (UTC)
web 🕒 Building (View Logs) Web Jan 16, 2026 at 2:24 pm

@railway-app
railway-app Bot temporarily deployed to OpenChat / openchat-pr-509 January 16, 2026 14:23 Destroyed
@github-actions

Copy link
Copy Markdown
Contributor

🚀 Preview Deployment Ready

Environment URL
Frontend https://web-openchat-pr-509.up.railway.app
Convex Dashboard Dashboard

Convex Preview Backend

  • Cloud URL: https://effervescent-lobster-245.convex.cloud
  • Site URL: https://effervescent-lobster-245.convex.site

🤖 Deployed automatically by GitHub Actions

@greptile-apps

greptile-apps Bot commented Jan 16, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

Optimized logo.svg from 2289 to 332 bytes (85% reduction) by consolidating 28 individual <rect> elements into a single <path> element, and properly configured favicon links with SVG-first approach for modern browsers with ICO fallback for legacy support.

Key Changes:

  • Replaced verbose rectangle-based SVG with optimized path-based version
  • Added manifest.json link for PWA support
  • Set SVG favicon as primary icon (type="image/svg+xml")
  • Maintained ICO fallback with explicit sizes="32x32" attribute
  • Preserved correct icon order (SVG before ICO) as recommended
  • All changes maintain visual consistency while significantly improving performance

Confidence Score: 5/5

  • This PR is safe to merge with no risk - it's a well-executed optimization that improves performance without changing functionality
  • The changes are purely cosmetic optimizations with zero behavioral changes. The SVG optimization reduces file size by 85% while maintaining identical visual output, and the favicon configuration follows modern best practices with proper fallbacks. The manifest.json already exists and is properly configured.
  • No files require special attention

Important Files Changed

Filename Overview
apps/web/public/logo.svg Optimized from 2289 to 332 bytes (85% reduction) by replacing 28 <rect> elements with single <path> element
apps/web/src/routes/__root.tsx Added SVG favicon with proper fallback order and PWA manifest link

Sequence Diagram

sequenceDiagram
    participant Browser
    participant HTML
    participant SVG as logo.svg
    participant ICO as favicon.ico
    participant Manifest as manifest.json

    Browser->>HTML: Load page
    HTML->>Manifest: Link manifest.json (PWA)
    HTML->>SVG: Request favicon (type: image/svg+xml)
    
    alt Modern browser with SVG support
        SVG-->>Browser: Return optimized 332-byte SVG
        Note over Browser,SVG: 85% smaller than original
    else Legacy browser without SVG support
        Browser->>ICO: Fallback to favicon.ico
        ICO-->>Browser: Return ICO (32x32)
    end
    
    Note over Browser: Display favicon in tab/bookmarks
Loading

@leoisadev1
leoisadev1 merged commit 37bbcc7 into main Jan 16, 2026
5 checks passed
@leoisadev1
leoisadev1 deleted the svg-favicon-optimization branch January 16, 2026 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants