fix(web): eliminate model selector flicker on rapid toggling - #499
Merged
Conversation
- Replace CSS animations with CSS transitions for smoother state changes - Keep portal mounted after first open (hasEverOpened pattern) - Use flushSync for atomic state updates to prevent intermediate renders - Add pointer-events-none when hidden to prevent interaction - Add scrollbar-gutter: stable for layout stability - Add data-state=closed overflow:hidden for clean exit animations
|
🚅 Deployed to the openchat-pr-499 environment in OpenChat
|
Contributor
🚀 Preview Deployment Ready
Convex Preview Backend
🤖 Deployed automatically by GitHub Actions |
Member
Author
|
@greptile review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
hasEverOpenedpattern) to prevent unmount/remount flickerflushSyncto batch state changes and prevent intermediate renderspointer-events-nonewhen hidden to prevent interaction with invisible contentscrollbar-gutter: stableto prevent layout shifts[data-state="closed"] { overflow: hidden }for clean exit transitionsTechnical Details
The flicker was caused by:
The fix follows patterns from production UI libraries (Radix UI, Headless UI):
flushSyncfor atomic state updates