fix(analytics): remove dev-only debug mode - #486
Merged
Conversation
|
🚅 Deployed to the openchat-pr-486 environment in OpenChat
|
Contributor
🚀 Preview Deployment Ready
Convex Preview Backend
🤖 Deployed automatically by GitHub Actions |
Contributor
Greptile SummaryThis PR removes the conditional environment logic for OneDollarStats analytics script. Previously, the script loaded with a Key changes:
Impact: Confidence Score: 5/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant User
participant Browser
participant Root as __root.tsx
participant OneDollar as OneDollarStats Script
User->>Browser: Navigate to app
Browser->>Root: Render root route
Root->>Root: Execute head() function
Note over Root: Generate meta tags, links, scripts
Root->>Browser: Return head config with scripts array
Browser->>Browser: Parse scripts configuration
Browser->>OneDollar: Load stonks.js (deferred)
Note over OneDollar: Script loads without data-debug attribute<br/>(same behavior in dev and prod)
OneDollar->>OneDollar: Initialize analytics tracking
Browser->>User: App renders with analytics enabled
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the conditional dev/prod logic for OneDollarStats. Now uses the same script in all environments.