[1.2] check/bump go version in Dockerfile #4998
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [actions/checkout](https://github.com/actions/checkout) from 4 to 5. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v4...v5) --- updated-dependencies: - dependency-name: actions/checkout dependency-version: '5' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> (cherry picked from commit cfb22c9) Signed-off-by: Kir Kolyshkin <[email protected]>
For some reason, some jobs in .github/workflows/validate.yml have "fetch-depth: 0" argument to actions/checkout, meaning "all history for all branches and tags". Obviously this is not needed here. Signed-off-by: Kir Kolyshkin <[email protected]> (cherry picked from commit e0b0017) Signed-off-by: Kir Kolyshkin <[email protected]>
Contributor
Author
|
Failed CI as expected:
Now adding a commit to bump Go to 1.23 in Dockerfile. |
Contributor
Author
|
Succeeds after Go version bump in Dockerfile:
|
kolyshkin
changed the title
This is to ensure that Go version in Dockerfile (which is used to build release binaries) is: - currently supported; - used in CI tests. Signed-off-by: Kir Kolyshkin <[email protected]> (cherry picked from commit df4acc8) Signed-off-by: Kir Kolyshkin <[email protected]>
Since Go 1.23 is no longer supported, we should not use it. Go 1.23 is still supported and is probably the best bet for the release-1.2 branch. Signed-off-by: Kir Kolyshkin <[email protected]>
kolyshkin
force-pushed
the
1.2-check-go
branch
from
3e6be57 to
ac2647a
Compare
cyphar
approved these changes
Nov 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of #4997 (and #4850) to release-1.2, plus a bump of GO_VERSION in Dockefile to a supported version.
Related to #4969 / alternative to #4987.
Fails CI without bumping Go version in Dockerfile to a supported release:
CI is green with the Go version bump: