Update DASH eni & port counters#2251
Open
arunp-dev wants to merge 2 commits intoopencomputeproject:masterfrom
Open
Update DASH eni & port counters#2251arunp-dev wants to merge 2 commits intoopencomputeproject:masterfrom
arunp-dev wants to merge 2 commits intoopencomputeproject:masterfrom
Conversation
update DASH counters (from sonic-net/SONiC#2139 + new additions) Signed-off-by: arun p <arunp@pensando.io>
arunp-dev
force-pushed
the
dash-counters
branch
from
4569c64 to
b58ddab
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
@marian-pritsak for review |
There was a problem hiding this comment.
Pull request overview
This pull request updates DASH (Disaggregated API for SONiC Hosts) counters for ENI (Elastic Network Interface) and port statistics based on requirements from sonic-net/SONiC issue #2139. The PR adds comprehensive telemetry capabilities for tracking session management, TCP state transitions, traffic drops, and High Availability (HA) synchronization.
Changes:
- Added FINACK acronym definition to meta/acronyms.txt
- Added 5 new port-level drop counters in experimental/saiportextensions.h
- Added 65 new ENI statistics covering session tracking, TCP state management, drop reasons, and HA sync metrics in experimental/saiexperimentaldasheni.h
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| meta/acronyms.txt | Added FINACK (TCP FINish ACKnowledgment) acronym for use in counter documentation |
| experimental/saiportextensions.h | Added 5 new port-level drop packet counters for invalid UDP source ports, session table full, invalid sessions, invalid mirror sessions, and IP fragments |
| experimental/saiexperimentaldasheni.h | Added 65 new ENI statistics including active session tracking by protocol, session lifecycle counters, TCP state tracking, CPS metrics, various drop reasons, and HA inline sync counters |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
update DASH counters (from sonic-net/SONiC#2139 + new additions)