Skip to content

add final step for branch protection#2501

Merged
micbar merged 2 commits intomainfrom
final-step
Mar 23, 2026
Merged

add final step for branch protection#2501
micbar merged 2 commits intomainfrom
final-step

Conversation

@ScharfViktor
Copy link
Contributor

@ScharfViktor ScharfViktor commented Mar 20, 2026

related: opencloud-eu/qa#81

image

Now the all-check-finished returns exit(0) if all tests pass, or exit(1) if any tests fail—we made this step required to protect the branch

@ScharfViktor ScharfViktor added the Type:DevOps Related to CI/CD label Mar 20, 2026
@ScharfViktor ScharfViktor marked this pull request as ready for review March 20, 2026 09:50
@sonarqubecloud
Copy link

Copy link
Contributor

@individual-it individual-it left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would mean that the chat notification step will also show as "fail" when there are other failed steps, but that should be OK, because in that case CI is already red

@ScharfViktor
Copy link
Contributor Author

This would mean that the chat notification step will also show as "fail" when there are other failed steps, but that should be OK, because in that case CI is already red

yes, It will failed, but sends notification

Copy link
Member

@micbar micbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there.

@kulmann
Copy link
Member

kulmann commented Mar 23, 2026

Screenshot 2026-03-23 at 06 43 53

I don't know how to make github to like it 🙈 the status doesn't seem to be reported... edit: ah lol, my screenshot wasn't even from this PR. Is the status a push-thing? this PR here is green... nevermind then I guess.

@micbar micbar merged commit 7234115 into main Mar 23, 2026
60 checks passed
@micbar micbar deleted the final-step branch March 23, 2026 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Type:DevOps Related to CI/CD

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants