Dedupe & update idp service JS dependencies#2496
Dedupe & update idp service JS dependencies#2496pascalwengerter wants to merge 3 commits intoopencloud-eu:mainfrom
Conversation
|
@pascalwengerter the licensechecker is failing with: I guess it's just a matter of updating |
a63d06c to
0427467
Compare
@rhafer thanks for the swift reply, addressed that and found another JS-related improvement 🤓 |
rhafer
left a comment
There was a problem hiding this comment.
Small note about the used image. Looks good otherwise.
Dockerfile
Outdated
|
|
||
|
|
||
| FROM owncloudci/nodejs:18 AS generate | ||
| FROM owncloudci/nodejs:22 AS generate |
There was a problem hiding this comment.
Good catch. I think we should switch to "quay.io/opencloudeu/nodejs-ci:24" though. (That is also what we use in the builds steps in CI)
|
@pascalwengerter Sorry for the inconvenience, but I think you need to rebase the PR on top of latest main once more. We added some change regarding branch protection to the CI recently that prevent this PR from being merged. A rebase should fix that. |
6959388 to
8c6155c
Compare
|
@rhafer no problem, could've rebased before adding the comment earlier. Done so now |



Description
Related Issue
services/idp#2460