Skip to content

Groupware #1994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pbleser-oc wants to merge 215 commits into
base: main
Choose a base branch
from

groupware: pollute code with NOSONAR comments, and make a little more…

1ac5e3f
Select commit
Loading
Failed to load commit list.
Open

Groupware #1994

groupware: pollute code with NOSONAR comments, and make a little more…
1ac5e3f
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed Mar 24, 2026 in 53s

Quality Gate failed

Failed conditions
69 Security Hotspots
3.3% Duplication on New Code (required ≤ 3%)
E Security Rating on New Code (required ≥ A)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Annotations

Check warning on line 1350 in services/groupware/pkg/groupware/api_emails.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Complete the task associated to this TODO comment. 

See more on https://sonarcloud.io/project/issues?id=opencloud-eu_opencloud&issues=AZwzScA5iFdIOO1S-sjz&open=AZwzScA5iFdIOO1S-sjz&pullRequest=1994

Check warning on line 204 in tests/groupware/groupware.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer using an optional chain expression instead, as it's more concise and easier to read. 

See more on https://sonarcloud.io/project/issues?id=opencloud-eu_opencloud&issues=AZyfW11CnmZyYEEPc9le&open=AZyfW11CnmZyYEEPc9le&pullRequest=1994

Check warning on line 20 in services/groupware/pkg/server/http/option.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this 'context.Context' field and pass context as a parameter to methods that need it. 

See more on https://sonarcloud.io/project/issues?id=opencloud-eu_opencloud&issues=AZwzSb_0iFdIOO1S-sjo&open=AZwzSb_0iFdIOO1S-sjo&pullRequest=1994

Check warning on line 17 in services/auth-api/pkg/server/http/option.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this 'context.Context' field and pass context as a parameter to methods that need it. 

See more on https://sonarcloud.io/project/issues?id=opencloud-eu_opencloud&issues=AZwzSb8oiFdIOO1S-sjc&open=AZwzSb8oiFdIOO1S-sjc&pullRequest=1994

Check warning on line 46 in pkg/jmap/tools.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Group together these consecutive parameters of the same type. 

See more on https://sonarcloud.io/project/issues?id=opencloud-eu_opencloud&issues=AZwzScF_iFdIOO1S-snl&open=AZwzScF_iFdIOO1S-snl&pullRequest=1994

Check warning on line 1382 in services/groupware/pkg/groupware/api_emails.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Complete the task associated to this TODO comment. 

See more on https://sonarcloud.io/project/issues?id=opencloud-eu_opencloud&issues=AZwzScA5iFdIOO1S-sj1&open=AZwzScA5iFdIOO1S-sj1&pullRequest=1994

Check warning on line 445 in services/groupware/pkg/groupware/framework.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Complete the task associated to this TODO comment. 

See more on https://sonarcloud.io/project/issues?id=opencloud-eu_opencloud&issues=AZwzScBgiFdIOO1S-skj&open=AZwzScBgiFdIOO1S-skj&pullRequest=1994

Check warning on line 193 in services/groupware/pkg/groupware/framework.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Complete the task associated to this TODO comment. 

See more on https://sonarcloud.io/project/issues?id=opencloud-eu_opencloud&issues=AZwzScBgiFdIOO1S-skV&open=AZwzScBgiFdIOO1S-skV&pullRequest=1994

Check warning on line 704 in services/groupware/pkg/groupware/api_emails.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Complete the task associated to this TODO comment. 

See more on https://sonarcloud.io/project/issues?id=opencloud-eu_opencloud&issues=AZwzScA5iFdIOO1S-sjv&open=AZwzScA5iFdIOO1S-sjv&pullRequest=1994

Check warning on line 1307 in pkg/jscontact/model.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Complete the task associated to this TODO comment. 

See more on https://sonarcloud.io/project/issues?id=opencloud-eu_opencloud&issues=AZwzScHKiFdIOO1S-soO&open=AZwzScHKiFdIOO1S-soO&pullRequest=1994

Check warning on line 198 in services/groupware/pkg/groupware/framework.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Complete the task associated to this TODO comment. 

See more on https://sonarcloud.io/project/issues?id=opencloud-eu_opencloud&issues=AZwzScBgiFdIOO1S-skZ&open=AZwzScBgiFdIOO1S-skZ&pullRequest=1994

Check warning on line 16 in services/groupware/pkg/server/debug/option.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this 'context.Context' field and pass context as a parameter to methods that need it. 

See more on https://sonarcloud.io/project/issues?id=opencloud-eu_opencloud&issues=AZwzSb_8iFdIOO1S-sjp&open=AZwzSb_8iFdIOO1S-sjp&pullRequest=1994

Check failure on line 496 in pkg/jmap/integration_email_test.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Enable server hostname verification on this SSL/TLS connection. 

See more on https://sonarcloud.io/project/issues?id=opencloud-eu_opencloud&issues=AZwzScGfiFdIOO1S-sn4&open=AZwzScGfiFdIOO1S-sn4&pullRequest=1994

Check warning on line 1833 in pkg/jscalendar/model.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Complete the task associated to this TODO comment. 

See more on https://sonarcloud.io/project/issues?id=opencloud-eu_opencloud&issues=AZwzScHxiFdIOO1S-soe&open=AZwzScHxiFdIOO1S-soe&pullRequest=1994

Check warning on line 156 in pkg/jmap/integration_test.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this 'context.Context' field and pass context as a parameter to methods that need it. 

See more on https://sonarcloud.io/project/issues?id=opencloud-eu_opencloud&issues=AZwzScEIiFdIOO1S-smr&open=AZwzScEIiFdIOO1S-smr&pullRequest=1994

Check warning on line 1360 in pkg/jmap/model.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this interface to follow Go naming conventions for single-method interfaces. 

See more on https://sonarcloud.io/project/issues?id=opencloud-eu_opencloud&issues=AZwzScFfiFdIOO1S-snO&open=AZwzScFfiFdIOO1S-snO&pullRequest=1994

Check warning on line 38 in services/groupware/pkg/groupware/dns.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Complete the task associated to this TODO comment. 

See more on https://sonarcloud.io/project/issues?id=opencloud-eu_opencloud&issues=AZwzScBUiFdIOO1S-skO&open=AZwzScBUiFdIOO1S-skO&pullRequest=1994

Check warning on line 119 in services/groupware/pkg/groupware/request.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Group together these consecutive parameters of the same type. 

See more on https://sonarcloud.io/project/issues?id=opencloud-eu_opencloud&issues=AZwzScB1iFdIOO1S-sk5&open=AZwzScB1iFdIOO1S-sk5&pullRequest=1994

Check warning on line 118 in services/groupware/pkg/groupware/dns.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Complete the task associated to this TODO comment. 

See more on https://sonarcloud.io/project/issues?id=opencloud-eu_opencloud&issues=AZwzScBUiFdIOO1S-skP&open=AZwzScBUiFdIOO1S-skP&pullRequest=1994

Check warning on line 196 in services/groupware/pkg/groupware/request.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Complete the task associated to this TODO comment. 

See more on https://sonarcloud.io/project/issues?id=opencloud-eu_opencloud&issues=AZwzScB1iFdIOO1S-sk0&open=AZwzScB1iFdIOO1S-sk0&pullRequest=1994

Check warning on line 20 in services/auth-api/pkg/config/config.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this 'context.Context' field and pass context as a parameter to methods that need it. 

See more on https://sonarcloud.io/project/issues?id=opencloud-eu_opencloud&issues=AZwzSb-kiFdIOO1S-sje&open=AZwzSb-kiFdIOO1S-sje&pullRequest=1994

Check warning on line 227 in services/groupware/pkg/groupware/framework.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Complete the task associated to this TODO comment. 

See more on https://sonarcloud.io/project/issues?id=opencloud-eu_opencloud&issues=AZwzScBgiFdIOO1S-skd&open=AZwzScBgiFdIOO1S-skd&pullRequest=1994

Check warning on line 201 in tests/groupware/groupware.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer using an optional chain expression instead, as it's more concise and easier to read. 

See more on https://sonarcloud.io/project/issues?id=opencloud-eu_opencloud&issues=AZyfW11CnmZyYEEPc9lb&open=AZyfW11CnmZyYEEPc9lb&pullRequest=1994

Check failure on line 533 in pkg/jmap/integration_test.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Enable server certificate validation on this SSL/TLS connection. 

See more on https://sonarcloud.io/project/issues?id=opencloud-eu_opencloud&issues=AZwzScEIiFdIOO1S-sma&open=AZwzScEIiFdIOO1S-sma&pullRequest=1994

Check warning on line 10 in tests/groupware/groupware.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this unused import of 'Counter'. 

See more on https://sonarcloud.io/project/issues?id=opencloud-eu_opencloud&issues=AZwzScDRiFdIOO1S-slX&open=AZwzScDRiFdIOO1S-slX&pullRequest=1994
View more details on SonarQubeCloud