fix(claude): auto-detect CLAUDE_CODE_EXECUTABLE when spawning Claude ACP agent#164
Open
SiyaoZheng wants to merge 1 commit intoopenclaw:mainfrom
Open
fix(claude): auto-detect CLAUDE_CODE_EXECUTABLE when spawning Claude ACP agent#164SiyaoZheng wants to merge 1 commit intoopenclaw:mainfrom
SiyaoZheng wants to merge 1 commit intoopenclaw:mainfrom
Conversation
…ACP agent When claude-agent-acp is spawned via acpx, it internally calls the Claude Agent SDK's query() which spawns a Claude Code CLI subprocess. If CLAUDE_CODE_EXECUTABLE is not set and isStaticBinary() returns false (non-Bun environments), pathToClaudeCodeExecutable is undefined, causing the CLI subprocess to fail immediately with "Query closed before response received". This change detects when the Claude ACP agent is being spawned and automatically resolves the claude CLI path via `which` or common install locations, setting CLAUDE_CODE_EXECUTABLE in the child process environment. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
acpx claude execspawnsclaude-agent-acp, the adapter internally calls@anthropic-ai/claude-agent-sdk'squery()which spawns a Claude Code CLI subprocessCLAUDE_CODE_EXECUTABLEis not set and the adapter'sisStaticBinary()returns false (non-Bun environments),pathToClaudeCodeExecutableis left undefinedinitializationResult()throws "Query closed before response received"claudeCLI path viawhichand common install locations when spawning the Claude ACP agent, settingCLAUDE_CODE_EXECUTABLEin the child process environmentReproduction
Test plan
npx tsc --noEmitpassesnpm run buildsucceedsacpx claude exec "Reply with exactly: OK"returns correct response~/.local/bin/claude🤖 Generated with Claude Code