feat: generic model selection via ACP session/set_model#150
Open
ironerumi wants to merge 1 commit intoopenclaw:mainfrom
Open
feat: generic model selection via ACP session/set_model#150ironerumi wants to merge 1 commit intoopenclaw:mainfrom
ironerumi wants to merge 1 commit intoopenclaw:mainfrom
Conversation
Add agent-agnostic model selection that works across any ACP agent implementing session/set_model (e.g. Droid, Gemini), not tied to any agent's _meta conventions. - --model <id> flag at spawn time calls session/set_model after session creation when agent advertises available models - `acpx <agent> set model <id>` mid-session routes through session/set_model instead of session/set_config_option - Model state tracking, caching, and status enrichment - Graceful degradation: agents without model support skip silently; ACP-coded rejections produce clear error messages - Model cache only updated on successful set (not on rejection) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--model <id>at session creation callssession/set_modelwhen agent advertises modelsacpx <agent> set model <id>routes throughsession/set_modelinstead ofsession/set_config_optionTest plan
tsc --noEmit)Closes #148
Partially addresses #49
🤖 Generated with Claude Code