Skip to content

fix ecto 3.12 incompatability#105

Open
novaugust wants to merge 2 commits into
opencinemac:devfrom
Frameio:main
Open

fix ecto 3.12 incompatability#105
novaugust wants to merge 2 commits into
opencinemac:devfrom
Frameio:main

Conversation

@novaugust

Copy link
Copy Markdown

removes private api usage

@peake100

peake100 commented Sep 7, 2024

Copy link
Copy Markdown
Contributor

Thanks for the PR!

@peake100

peake100 commented Sep 7, 2024

Copy link
Copy Markdown
Contributor

Would you mind closing this PR and reopening against dev instead? CI is set to run on the dev branch, then cut a release to main when dev is updated.

@peake100 peake100 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See above

@novaugust
novaugust changed the base branch from main to dev September 9, 2024 14:20
@novaugust

Copy link
Copy Markdown
Author

Would you mind closing this PR and reopening against dev instead? CI is set to run on the dev branch, then cut a release to main when dev is updated.

edited! for future reference, you can hit "edit" on the PR and change which branch it's pointed at.

@peake100

peake100 commented Sep 9, 2024

Copy link
Copy Markdown
Contributor

Hey! Sorry, I should have been a little more clear. Your branch is still based on main, which includes some build artifacts not found in dev. You can see them in the diff.

Do you mind targeting your fork's dev to the main repo's dev?

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants