fix(setup): GKE tweaks, gateway-hostname capture, stable-version filter#13
Draft
rashadism wants to merge 1 commit into
Draft
fix(setup): GKE tweaks, gateway-hostname capture, stable-version filter#13rashadism wants to merge 1 commit into
rashadism wants to merge 1 commit into
Conversation
cc5a3cf to
d1fa729
Compare
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
d1fa729 to
30df2e7
Compare
- on-your-environment.md: add GKE platform tweaks — async LB provisioning (pending IP isn't a failure) and the fluentbit-gke port-2020 conflict (hostNetwork:false + Use_Kubelet Off) - fetch-page.sh / list-versions.sh: resolve latest-stable by matching a plain vX.Y.x / vX.Y.Z positively rather than denylisting pre-release suffixes, so milestone tags (e.g. v1.2.0-m.1) aren't served as stable Signed-off-by: Rashad Sirajudeen <rashad@wso2.com>
30df2e7 to
3f4f20f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From a multi-cluster GKE install run.
fluentbit-gkeDaemonSet owns host port 2020 (install the logs module's fluent-bit withhostNetwork:false+Use_Kubelet Off, else records ship withoutkubernetes.*fields and the logs adapter rejects them).vX.Y.x/vX.Y.Zpositively instead of denylisting known pre-release suffixes, so milestone tags (e.g.v1.2.0-m.1, currently the top entry in versions.json) aren't served as "latest stable".