Skip to content

fix: preserve native types in xray span-details attributes#227

Open
rashadism wants to merge 1 commit into
openchoreo:mainfrom
rashadism:fix/xray-span-attribute-types
Open

fix: preserve native types in xray span-details attributes#227
rashadism wants to merge 1 commit into
openchoreo:mainfrom
rashadism:fix/xray-span-attribute-types

Conversation

@rashadism

Copy link
Copy Markdown
Contributor

Builds X-Ray SpanDetail attributes/resourceAttributes as native map[string]interface{} (dropping the per-value fmt.Sprintf), so numbers and objects keep their types in span-details (openchoreo/openchoreo#3886). Removes the now-unused SpanAttribute type; the list path already used native maps.

Regenerated against the map-typed schema. Depends on #225 (spec repoint) and openchoreo/openchoreo#3913 (spec change) — codegen/release reconcile once those land.

Build SpanDetail attributes/resourceAttributes as native maps instead of
stringified {key, value} pairs (drop fmt.Sprintf), regenerated against the
map-typed spec. Removes the now-unused SpanAttribute type.

Part of openchoreo/openchoreo#3886

Signed-off-by: Rashad Sirajudeen <rashad@wso2.com>
@coderabbitai

coderabbitai Bot commented Jun 18, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@rashadism, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 18 minutes and 33 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, the refill rate gradually slows as usage increases. The highest same-day bursts are limited more strictly.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: e2334877-a496-4adb-8075-840e1af7316e

📥 Commits

Reviewing files that changed from the base of the PR and between 81325fe and ff00738.

⛔ Files ignored due to path filters (2)
  • observability-tracing-aws-xray/internal/api/gen/models.gen.go is excluded by !**/gen/**
  • observability-tracing-aws-xray/internal/api/gen/server.gen.go is excluded by !**/gen/**
📒 Files selected for processing (4)
  • observability-tracing-aws-xray/internal/handlers.go
  • observability-tracing-aws-xray/internal/xray/client.go
  • observability-tracing-aws-xray/internal/xray/queries.go
  • observability-tracing-aws-xray/internal/xray/queries_test.go
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 16.66667% with 20 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...bservability-tracing-aws-xray/internal/handlers.go 0.00% 14 Missing ⚠️
...vability-tracing-aws-xray/internal/xray/queries.go 40.00% 6 Missing ⚠️

📢 Thoughts on this report? Let us know!

@rashadism rashadism marked this pull request as ready for review June 19, 2026 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants