-
Notifications
You must be signed in to change notification settings - Fork 39
make cancel buttons work for users/groups/access #1277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi @ppettit |
|
Use Run test server using develop.opencast.org as backend: Specify a different backend like stable.opencast.org: It may take a few seconds for the interface to spin up. |
|
This pull request is deployed at test.admin-interface.opencast.org/1277/2025-05-14_12-02-36/ . |
|
Supercedes #1204 I suppose? |
Arnei
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works and makes sense to me. Small suggestion below
yes, sorry that was not linked to the issue so i didn't find it. seems like a lot of unrelated changes in that PR too |
* upstream/r/17.x: (191 commits) Revert "Merge branch 'seperate-user-and-non-user-roles' of Arnei/opencast-admin-interface into main" Automatically update translation keys Uncheck 'Select all' header cell on page change (opencast#1196) Automatically update translation keys Changing themes of series fixed (opencast#1254) Display only directly assigned roles in user modal (opencast#1251) Reactivated location table sorting by udated date Implement broadcast synchronization for logout events and user authentication (opencast#1274) make cancel buttons work for users/groups/access (opencast#1277) Different text for bottom set of roles in ACL view make sure override is there where needed make override optional Modernize the `Dockerfile` deselect all items in the table before sorting Minor eslint fixes Fix checkbox name for contact me field in RegistrationModal fix overlapping notifications + add title in upload notification minor fixes Add override button functionality to access policy components for series, Add two tabs indentation ...
Fixes #1182
Just makes the cancel button close the modal which is the behaviour of the old admin UI