Skip to content

Conversation

@ppettit
Copy link
Contributor

@ppettit ppettit commented May 14, 2025

Fixes #1182

Just makes the cancel button close the modal which is the behaviour of the old admin UI

@github-actions
Copy link
Contributor

Hi @ppettit
Thank you for contributing to the Opencast Admin UI.
We noticed that you have not yet filed an Individual Contributor License Agreement. Doing that (once) helps us to ensure that Opencast stays free for all. If you make your contribution on behalf of an institution, you might also want to file a Corporate Contributor License Agreement (giving you as individual contributor a bit more security as well). It can take a while for this bot to find out about new filings, so if you just filed one or both of the above do not worry about this message!
Please let us know if you have any questions regarding the CLA.

@github-actions
Copy link
Contributor

Use docker or podman to test this pull request locally.

Run test server using develop.opencast.org as backend:

podman run --rm -it -p 127.0.0.1:3000:3000 ghcr.io/opencast/opencast-admin-interface:pr-1277

Specify a different backend like stable.opencast.org:

podman run --rm -it -p 127.0.0.1:3000:3000 -e PROXY_TARGET=https://stable.opencast.org ghcr.io/opencast/opencast-admin-interface:pr-1277

It may take a few seconds for the interface to spin up.
It will then be available at http://127.0.0.1:3000.
For more options you can pass on to the proxy, take a look at the README.md.

@github-actions
Copy link
Contributor

github-actions bot commented May 14, 2025

This pull request is deployed at test.admin-interface.opencast.org/1277/2025-05-14_12-02-36/ .
It might take a few minutes for it to become available.

@NadiaUoM NadiaUoM added the type:bug Something isn't working label May 14, 2025
@Arnei
Copy link
Member

Arnei commented May 14, 2025

Supercedes #1204 I suppose?

Copy link
Member

@Arnei Arnei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works and makes sense to me. Small suggestion below

@ppettit
Copy link
Contributor Author

ppettit commented May 14, 2025

Supercedes #1204 I suppose?

yes, sorry that was not linked to the issue so i didn't find it. seems like a lot of unrelated changes in that PR too

@Arnei Arnei merged commit 3e5ace0 into opencast:main May 15, 2025
5 checks passed
mtneug added a commit to tales-media/fork-opencast-opencast-admin-interface that referenced this pull request Jun 1, 2025
* upstream/r/17.x: (191 commits)
  Revert "Merge branch 'seperate-user-and-non-user-roles' of Arnei/opencast-admin-interface into main"
  Automatically update translation keys
  Uncheck 'Select all' header cell on page change (opencast#1196)
  Automatically update translation keys
  Changing themes of series fixed (opencast#1254)
  Display only directly assigned roles in user modal (opencast#1251)
  Reactivated location table sorting by udated date
  Implement broadcast synchronization for logout events and user authentication (opencast#1274)
  make cancel buttons work for users/groups/access (opencast#1277)
  Different text for bottom set of roles in ACL view
  make sure override is there where needed
  make override optional
  Modernize the `Dockerfile`
  deselect all items in the table before sorting
  Minor eslint fixes
  Fix checkbox name for contact me field in RegistrationModal
  fix overlapping notifications + add title in upload notification
  minor fixes
  Add override button functionality to access policy components for series,
  Add two tabs indentation
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type:bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cancel button not working while editing User/Groups/Access policies tab

3 participants