Add feedback upload request handling #5682
Conversation
|
Codex Review: Something went wrong. Try again later by commenting “@codex review”. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
@codex review this |
|
Codex Review: Something went wrong. Try again later by commenting “@codex review”. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
@codex review |
|
Codex Review: Something went wrong. Try again later by commenting “@codex review”. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
| #[serde(skip_serializing_if = "Option::is_none")] | ||
| pub reason: Option<String>, | ||
| #[serde(skip_serializing_if = "Option::is_none")] | ||
| pub conversation_id: Option<ConversationId>, |
There was a problem hiding this comment.
We still call it ConversationId tho
| .get_conversation(conversation_id) | ||
| .await | ||
| { | ||
| Ok(conv) => Some(conv.rollout_path()), |
There was a problem hiding this comment.
Didn't we have an Op to get rollout path? Let's stick to it even though I don't like it.
There was a problem hiding this comment.
We cannot receive the events here because we are doing it in a loop
There was a problem hiding this comment.
Can we use this new method in other callsites?
There was a problem hiding this comment.
Different PR?
There was a problem hiding this comment.
All callers of codex.submit(Op::GetPath) can be find-replaced to codex.rollout_path()
2 participants
Summary
feedback/uploadJSON-RPC request to the app server protocol and wire it through the message processorTesting
cargo test -p codex-app-server-protocolcargo test -p codex-app-server(fails: Loopback targets forbidden when hitting mock HTTP servers)https://chatgpt.com/codex/tasks/task_i_68fd0d98ee488321b72d52514a822a8e