feat(cli): teach completion scripts to surface config profiles #5651
+247
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
coder543
force-pushed
the
feature/profiles-completion
branch
from
5a8cf0c to
e5771d9
Compare
Generate dynamic `--profile` suggestions for fish, bash, and zsh by appending small helpers that call `codex profiles list`. Each script now delegates profile name discovery to the CLI instead of guessing from the filesystem, so completions stay accurate as users edit `config.toml`. Add a lightweight `codex profiles list` subcommand to feed those helpers and write integration tests that assert the command output is wired into every supported shell. Update the configuration docs to mention the inspection command for users who prefer to check profiles manually.
coder543
force-pushed
the
feature/profiles-completion
branch
from
e5771d9 to
eedca2c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
This small PR was written to solve a pain point I was experiencing. In trying to use the profiles feature extensively with local LLMs including
gpt-oss-20bandgpt-oss-120b, I wanted to be able to more quickly type out the names, and I wanted to avoid the need to reference theconfig.tomlfile to remember names, so I added tab completion. Originally developed forfish, but I added support forbashandzshas well.Description
Generates dynamic
--profilesuggestions for fish, bash, and zsh by appending small helpers that callcodex profiles list. Each script now delegates profile name discovery to the CLI instead of guessing from the filesystem, so completions stay accurate as users editconfig.toml.Adds a lightweight
codex profiles listsubcommand to feed those helpers and writes integration tests that assert the command output is wired into every supported shell. Updates the configuration docs to mention the inspection command for users who prefer to check profiles manually.(I wish there were a more elegant way to support dynamic completions in
clap, but modifying your own custom completions into the output is the most elegant way that appears to be available.clapstill does most of the work.)