Repository navigation
Add connection-bound reply handles for app-server requests - #53049
Merged
copyberry[bot] merged 1 commit intoOct 11, 2026
Conversation
## Why Server request IDs can be reused across connections. Retained replies need to target the connection that emitted the request, even if the UI selection later changes. ## What changed - Expose `AppServerReplyHandle` through `AppServerRequestHandle::server_request_reply_handle`, capturing the originating client and request ID for explicit `resolve` or `reject` calls. - Share single-use completion state across clones so only the first reply is submitted. Dropping a handle sends nothing; stale connections return I/O errors without retrying or switching connections. - Route existing client reply methods through request handles and use the new API in the managed worktree model test. ## Testing Add in-process and WebSocket tests for replies on separate connections with identical request IDs, rejection routing, duplicate completion, and stale handles after worker shutdown. Also check that debug output redacts handle details. GitOrigin-RevId: 940d0951ab67529b05919ca8ec7adb5813834b8c
copyberry
Bot
force-pushed
the
copyberry/codex-internal-to-codex-oss/940d0951ab67529b05919ca8ec7adb5813834b8c
branch
from
October 11, 2026 06:08
3fd44fa to
8c0f701
Compare
Contributor
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
copyberry
Bot
deleted the
copyberry/codex-internal-to-codex-oss/940d0951ab67529b05919ca8ec7adb5813834b8c
branch
October 11, 2026 06:08
Contributor
|
I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
miaomiao111miaomiao-ctrl
deployed
to
issue-triage
October 11, 2026 06:44 — with
GitHub Actions
Active
miaomiao111miaomiao-ctrl
deployed
to
issue-triage
October 11, 2026 06:44 — with
GitHub Actions
Active
miaomiao111miaomiao-ctrl
deployed
to
issue-triage
October 11, 2026 06:44 — with
GitHub Actions
Active
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add connection-bound reply handles for app-server requests
Why
Server request IDs can be reused across connections. Retained replies need to target the connection that emitted the request, even if the UI selection later changes.
What changed
AppServerReplyHandlethroughAppServerRequestHandle::server_request_reply_handle, capturing the originating client and request ID for explicitresolveorrejectcalls.Testing
Add in-process and WebSocket tests for replies on separate connections with identical request IDs, rejection routing, duplicate completion, and stale handles after worker shutdown. Also check that debug output redacts handle details.