Skip to content

Conversation

@JerryVincent
Copy link
Collaborator

@JerryVincent JerryVincent commented Oct 29, 2025

Type of Change

User was not able to update or view their current profile image in the /settings/profile route. The update icon was disabled. Also, the files in the resources+ directory has been moved outside the directory and renamed as resources.fileName in the routes folder, as the react-router does not identify these routes in the resources folder.

  • Dependency upgrade
  • [✔️] Bug fix (non-breaking change)
  • Breaking change
    • e.g. a fixed bug or new feature that may break something else
  • New feature
  • Code quality improvements
    • e.g. refactoring, documentation, tests, tooling, ...

Implementation

I have updated the action function in the /settings/profile/photo route. Earlier, it was deleting the same photo that was recently added. In the /settings/profile route, i enabled pointer events for the link element right below the Avatar element because it was disabled before, which prevents the user from updating their profile picture. I removed all the files in the resources+ directory to outside the directory and inside the routes directory and renamed them as resources.fileName, as the react-router was not recognising these routes in the resources+ directory.

Checklist

  • [✔️] I gave this pull request a meaningful title
  • [✔️] My pull request is targeting the dev branch
  • [✔️] I have added documentation to my code
  • [✔️] I have deleted code that I have commented out

Additional Information

… resources+ folder as the react router doesn't support this.
@scheidtdav
Copy link
Collaborator

Functionality works well, thanks for that.
However, I did find a small glitch/ bugs that you could have a look at before we merge this:

  • The X button in the top right of the dialog does not close the dialog when clicked:
image

@JerryVincent
Copy link
Collaborator Author

JerryVincent commented Nov 5, 2025 via email

@scheidtdav scheidtdav removed their request for review November 5, 2025 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Can't change profile image from the '/settings/profile' route, under the 'public profile' tab.

3 participants