-
Notifications
You must be signed in to change notification settings - Fork 54
Fix AppVeyor 64bit build #1832
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix AppVeyor 64bit build #1832
Conversation
e22c79f to
19d9bb9
Compare
19d9bb9 to
0d6c9a2
Compare
Use force to address for tge `legacy_datasets.tar`
```
Move-Item : Cannot create a file when that file already exists.
At C:\projects\openpmd-api\share\openPMD\download_samples.ps1:30 char:1
+ Move-Item -Path legacy_datasets\* samples\git-sample\legacy\
+ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+ CategoryInfo : WriteError: (C:\projects\ope...5.0-hdf5-plugin:DirectoryInfo) [Move-Item], IOException
+ FullyQualifiedErrorId : MoveDirectoryItemIOError,Microsoft.PowerShell.Commands.MoveItemCommand
```
Architecture not part of `-G` anymore, maybe `-A x64`
0d6c9a2 to
39af352
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've pushed a fix for the build error, hoping that the CI will pass, if yes, then this looks good. Thank you!
|
Yay, only to fails left: Unittest.pyExample.py.7_extended_write_serial |
1fa68ad to
4045aa2
Compare
4045aa2 to
085ef1c
Compare
Fix: `TypeError: data type 'ulong' not understood` on GCC 9 w/ Python 3.10 on Linux.
|
On CF, we further see on Win64 these linker errors: conda-forge/openpmd-api-feedstock#130 |
Slightly more consistent
|
Ah, the patch above from Franz fixes exactly that. Moved that to CF. |
|
Not sure what is on with that Update: Ahhh, GH status
|
| Datatype dtype = determineDatatype<T>(); | ||
| if (dtype != getDatatype()) | ||
| if (dtype != getDatatype() && !isSameInteger<T>(getDatatype()) && | ||
| !isSameFloatingPoint<T>(getDatatype()) && | ||
| !isSameComplexFloatingPoint<T>(getDatatype()) && | ||
| !isSameChar<T>(getDatatype())) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not urgently needed but sensible.
We should group these together into a single call like isEquivalentRepresentation<T>(getDatatype()) where we use it in the code base.
The CMake Generator line for 64bit build was outdated and does not include the architecture anymore.
Use force to address for the
legacy_datasets.tar