This repository was archived by the owner on Jul 7, 2026. It is now read-only.
Fix: SwipeRefreshLayout spinning endlessly on the account section#217
Open
ksog66 wants to merge 2 commits into
Open
Fix: SwipeRefreshLayout spinning endlessly on the account section#217ksog66 wants to merge 2 commits into
ksog66 wants to merge 2 commits into
Conversation
ksog66
marked this pull request as ready for review
March 5, 2021 13:45
Collaborator
|
@ksog66 You have not followed the contribution guidelines. Please squash multiple commits into one. |
Author
|
@garvit984 Actually i didnt know about that , i am new to open source. can you help with it as i dont know what is squasing commit ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Fix
Fixes #216
Screenshots
WhatsApp.Video.2021-03-05.at.18.21.40.mp4
Description
Added code to stop the continuous spinning of SwipeRefreshLayout in account section and also added the action, it is supposed to do when refresh layout
Run the unit tests with
./gradlew checkto make sure you didn't break anythingIf you have multiple commits please combine them into one commit by squashing them.