Skip to content

Give lists persistent /lists/{handle}/{id} URLs - #1169

Open
mfortini wants to merge 2 commits into
open-wanderer:devfrom
mfortini:pr/list-persistent-urls
Open

Give lists persistent /lists/{handle}/{id} URLs#1169
mfortini wants to merge 2 commits into
open-wanderer:devfrom
mfortini:pr/list-persistent-urls

Conversation

@mfortini

Copy link
Copy Markdown
Contributor

Lists now use stable URLs with handle and id so that refreshing, sharing, or navigating back preserves the selected list and trail. The page loader fetches the selected list server-side and the search bar on /map links directly to the canonical list URL.

Lists now use stable URLs with handle and id so that refreshing,
sharing, or navigating back preserves the selected list and trail.
The page loader fetches the selected list server-side and the
search bar on /map links directly to the canonical list URL.

@slothful-vassal slothful-vassal left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this — the persistent URLs are a real improvement, and the '/map' search link is perfect. While testing, I came across three issues that I'd like to see addressed before merging:

  1. Infinite scroll drops entries

Repro: On the /lists page, scroll until page 2 loads (60 entries). Open a list from the second page, then use the browser back button to return to /lists and keep scrolling.

The result is that the 30 entries from page 2 disappear and the sidebar jumps from page 1 straight to page 3.

  1. The map no longer zooms out when deselecting.

Repro: Open a list — the map fits the list's BBOX correctly. Press Back.

The result is that the map stays on the previous list's box while the sidebar shows the global list index.

  1. The in-app Back button and the browser Back button behave differently.

Repro: From /lists, open a list, then press the in-app Back arrow and then the browser Back button.

Result: you will return to the list you just left.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants