-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Tune collector telemetry stability levels to match semconv #8558
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tune collector telemetry stability levels to match semconv #8558
Conversation
01a6325 to
f16885a
Compare
tiffany76
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some copy edit suggestions, but otherwise this LGTM! Thanks @ChrsMark!
b677037 to
1099be7
Compare
|
I have added an explicit note about suggesting working with Semantic Convention us much as possible: cbe1ce6 This is coming from open-telemetry/opentelemetry-collector#13910 (comment), but I'm happy to hear what do we think about this in general. |
|
/fix:refcache |
|
ℹ️ |
169842e to
cbe1ce6
Compare
cbe1ce6 to
448398e
Compare
|
I would also like to request a review from @codeboten since we extensively discussed these changes at open-telemetry/opentelemetry-collector#13910 :). |
448398e to
10073a6
Compare
🎁 |
Signed-off-by: ChrsMark <[email protected]>
10073a6 to
3c6a98b
Compare
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description This PR adds a guideline section about the stability levels the produced components' telemetry should follow. <!-- Issue number if applicable --> #### Link to tracking issue Related to open-telemetry/opentelemetry.io#8558 and #13910. --------- Signed-off-by: ChrsMark <[email protected]>
|
@mx-psi @open-telemetry/docs-approvers we should have enough approvals from the Collector SIG now. |
contribution guidelines,
including the First-time contributing? note.
the
Generative AI Contribution Policy.
This PR tunes the docs according to the first point of open-telemetry/opentelemetry-collector#13910 (comment):
@open-telemetry/collector-approvers @open-telemetry/collector-contrib-approvers please review.
PREVIEW: https://deploy-preview-8558--opentelemetry.netlify.app/docs/collector/internal-telemetry/#metrics