feat: implement on ending in span processor #4775
Open
+140
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
majanjua-amzn
force-pushed
the
main
branch
2 times, most recently
from
95797e2 to
41c988d
Compare
xrmx
reviewed
Oct 16, 2025
| parent_context: The parent context of the span that just started. | ||
| """ | ||
|
|
||
| def on_ending(self, span: "Span") -> None: |
There was a problem hiding this comment.
Since this is still in development in the specs we don't want to make it a public symbol yet, so this can be _on_ending. The same applies to the other methods as well
xrmx
reviewed
Oct 16, 2025
CHANGELOG.md
Outdated
| ([#4755](https://github.com/open-telemetry/opentelemetry-python/pull/4755)) | ||
| - logs: extend Logger.emit to accept separated keyword arguments | ||
| ([#4737](https://github.com/open-telemetry/opentelemetry-python/pull/4737)) | ||
| - feat: implement on ending in span processor |
There was a problem hiding this comment.
Needs to be moved to unreleased
There was a problem hiding this comment.
Weird, in my local it was put properly then changed when I pushed. Might've been the pre-commit hook. In any case, fixed, thanks
majanjua-amzn
force-pushed
the
main
branch
2 times, most recently
from
ed2fa0c to
708f178
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
SpanProcessor.onEnding() Specification
This PR serves to implement the in-development feature
onEnding()for the span processor. This will allow users to make modifications to the span before it becomes immutable whenonEnd()is reached.Loosely following implementation in Java repo: open-telemetry/opentelemetry-java#6367
Fixes: N/A
Type of change
New feature (non-breaking change which adds functionality)
How Has This Been Tested?
onEndingonStartandonEnd)Span.End())Does This PR Require a Contrib Repo Change?
No.
Checklist: