Implement filtering logic for min_severity and trace_based parameters #4765
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hectorhdzg
reviewed
Oct 7, 2025
opentelemetry-sdk/src/opentelemetry/sdk/_logs/_internal/__init__.py
Outdated
Show resolved
Hide resolved
hectorhdzg
reviewed
Oct 7, 2025
opentelemetry-sdk/src/opentelemetry/sdk/_logs/_internal/__init__.py
Outdated
Show resolved
Hide resolved
rads-1996
force-pushed
the
trace-based-sampling
branch
from
3557ca9 to
fa903d0
Compare
lzchen
reviewed
Oct 13, 2025
| ConcurrentMultiLogRecordProcessor, | ||
| ], | ||
| instrumentation_scope: InstrumentationScope, | ||
| min_severity_level: SeverityNumber = SeverityNumber.UNSPECIFIED, |
There was a problem hiding this comment.
I am a bit wary supporting concepts related to components that are still in development directly into the sdk, especially since we are trying to stabilize logging sdk. It seems like Go is taking the approach of implementing this internally via logrecordprocessors, perhaps this might be a better way so that we don't have to change the public api? Perhaps bring this up in the PYthon SIG.
aabmass
reviewed
Oct 16, 2025
| ConcurrentMultiLogRecordProcessor, | ||
| ], | ||
| instrumentation_scope: InstrumentationScope, | ||
| min_severity_level: SeverityNumber = SeverityNumber.UNSPECIFIED, |
There was a problem hiding this comment.
Is the LoggerConfigurator supposed to be on the LoggerProvider?
There was a problem hiding this comment.
@aabmass Yes, The LoggerProvider MUST compute the relevant LoggerConfig using the configured LoggerConfigurator, and create a Logger whose behavior conforms to that LoggerConfig.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implement Spec to filter logs based on
min_severityandtrace_basedparameters.Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Contrib Repo Change?
Checklist: