Feature: Include trace flags in spans exported by the OTLPSpanExporter #4761
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xrmx
reviewed
Oct 3, 2025
...roto-common/src/opentelemetry/exporter/otlp/proto/common/_internal/trace_encoder/__init__.py
Outdated
Show resolved
Hide resolved
xrmx
reviewed
Oct 3, 2025
...roto-common/src/opentelemetry/exporter/otlp/proto/common/_internal/trace_encoder/__init__.py
Outdated
Show resolved
Hide resolved
xrmx
reviewed
Oct 3, 2025
...roto-common/src/opentelemetry/exporter/otlp/proto/common/_internal/trace_encoder/__init__.py
Outdated
Show resolved
Hide resolved
xrmx
moved this from Ready for review
to Reviewed PRs that need fixes
in @xrmx's Python PR digest
|
@xrmx made changes as per your comments. thanks. |
xrmx
moved this from Reviewed PRs that need fixes
to Ready for review
in @xrmx's Python PR digest
xrmx
reviewed
Oct 10, 2025
exporter/opentelemetry-exporter-otlp-proto-common/tests/test_trace_encoder.py
Outdated
Show resolved
Hide resolved
exporter/opentelemetry-exporter-otlp-proto-common/tests/test_trace_encoder.py
Outdated
Show resolved
Hide resolved
exporter/opentelemetry-exporter-otlp-proto-common/tests/test_trace_encoder.py
Outdated
Show resolved
Hide resolved
|
@xrmx I have made the changes as u said. Can you take a lookg again? |
|
@xrmx can you trigger the workflows once? I have fixed the errors |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #4666
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Contrib Repo Change?
Checklist: